chrome/browser/sync/test/integration/search_engines_helper.cc - Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/search_engines_helper.cc

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more tests that don't set short_name Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search_engines/search_provider_install_data_unittest.cc ('k') | chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/search_engines_helper.cc

diff --git a/chrome/browser/sync/test/integration/search_engines_helper.cc b/chrome/browser/sync/test/integration/search_engines_helper.cc

index 083cb5b64194e2b13058a8298c3bf2249f1f79c6..0eb145523babf4d2bf98adf9d3e83372023f72ea 100644

--- a/chrome/browser/sync/test/integration/search_engines_helper.cc

+++ b/chrome/browser/sync/test/integration/search_engines_helper.cc

@@ -195,7 +195,7 @@ TemplateURL* CreateTestTemplateURL(Profile* profile,

const std::string& url,

const std::string& sync_guid) {

TemplateURLData data;

- data.short_name = CreateKeyword(seed);

+ data.SetShortName(CreateKeyword(seed));

data.SetKeyword(keyword);

data.SetURL(url);

data.favicon_url = GURL("http://favicon.url");