chrome/browser/search/instant_service_unittest.cc - Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/instant_service_unittest.cc

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more tests that don't set short_name Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc ('k') | chrome/browser/search/instant_unittest_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/instant_service_unittest.cc

diff --git a/chrome/browser/search/instant_service_unittest.cc b/chrome/browser/search/instant_service_unittest.cc

index 7d22a543b0f0047fa6e3ea4ff72f87dd560d2838..66253b745747dbb983cd4bca108f696ded48d7f7 100644

--- a/chrome/browser/search/instant_service_unittest.cc

+++ b/chrome/browser/search/instant_service_unittest.cc

@@ -8,6 +8,7 @@

#include "base/memory/scoped_ptr.h"

#include "base/metrics/field_trial.h"

#include "base/strings/string_util.h"

+#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/search/instant_service.h"

#include "chrome/browser/search/instant_service_observer.h"

#include "chrome/browser/search/instant_unittest_base.h"

@@ -128,6 +129,7 @@ TEST_F(InstantServiceEnabledTest,

// Set a default search provider that doesn't support Instant.

TemplateURLData data;

+ data.SetShortName(base::ASCIIToUTF16("foobar.com"));

data.SetURL("https://foobar.com/url?bar={searchTerms}");

TemplateURL* template_url = new TemplateURL(data);

// Takes ownership of |template_url|.