chrome/browser/autocomplete/zero_suggest_provider_unittest.cc - Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more tests that don't set short_name Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/shortcuts_backend_unittest.cc ('k') | chrome/browser/chrome_content_browser_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

diff --git a/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc b/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

index 5699e93def9c1a38efdb30216b5d11903b2de7e8..105efe7d388fe5a794814a71b2a1a6947f14f311 100644

--- a/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

+++ b/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

@@ -172,7 +172,7 @@ void ZeroSuggestProviderTest::SetUp() {

turl_model->Load();

TemplateURLData data;

- data.short_name = base::ASCIIToUTF16("t");

+ data.SetShortName(base::ASCIIToUTF16("t"));

data.SetURL("https://www.google.com/?q={searchTerms}");

data.suggestions_url = "https://www.google.com/complete/?q={searchTerms}";

data.instant_url = "https://does/not/exist?strk=1";