chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm - Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more tests that don't set short_name Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/search_engines_helper.cc ('k') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm b/chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm

index 355948c03a4a5b95ef70d5ac62645d68b1e154ca..be3cd690938f2d5fb3274a5ba7d4b93a7939c7a0 100644

--- a/chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm

@@ -232,7 +232,7 @@ TEST_F(EditSearchEngineControllerTest, ValidateFields) {

// Tests editing an existing TemplateURL.

TEST_F(EditSearchEngineControllerTest, EditTemplateURL) {

TemplateURLData data;

- data.short_name = base::ASCIIToUTF16("Foobar");

+ data.SetShortName(base::ASCIIToUTF16("Foobar"));

data.SetKeyword(base::ASCIIToUTF16("keyword"));

std::string urlString = TemplateURLRef::DisplayURLToURLRef(

base::ASCIIToUTF16("http://foo-bar.com"));