Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: components/search_engines/template_url_prepopulate_data_unittest.cc

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more tests that don't set short_name Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url_prepopulate_data_unittest.cc
diff --git a/components/search_engines/template_url_prepopulate_data_unittest.cc b/components/search_engines/template_url_prepopulate_data_unittest.cc
index 15f3b8b56a693d324442ebe52ff7eb3748404d2d..68bf84c9baaf6ac482fa653f9dc2677192c88df5 100644
--- a/components/search_engines/template_url_prepopulate_data_unittest.cc
+++ b/components/search_engines/template_url_prepopulate_data_unittest.cc
@@ -138,7 +138,7 @@ TEST_F(TemplateURLPrepopulateDataTest, ProvidersFromPrefs) {
&default_index);
ASSERT_EQ(1u, t_urls.size());
- EXPECT_EQ(ASCIIToUTF16("foo"), t_urls[0]->short_name);
+ EXPECT_EQ(ASCIIToUTF16("foo"), t_urls[0]->short_name());
EXPECT_EQ(ASCIIToUTF16("fook"), t_urls[0]->keyword());
EXPECT_EQ("foo.com", GetHostFromTemplateURLData(*t_urls[0]));
EXPECT_EQ("foi.com", t_urls[0]->favicon_url.host());
@@ -163,7 +163,7 @@ TEST_F(TemplateURLPrepopulateDataTest, ProvidersFromPrefs) {
t_urls = TemplateURLPrepopulateData::GetPrepopulatedEngines(
&prefs_, &default_index);
ASSERT_EQ(1u, t_urls.size());
- EXPECT_EQ(ASCIIToUTF16("foo"), t_urls[0]->short_name);
+ EXPECT_EQ(ASCIIToUTF16("foo"), t_urls[0]->short_name());
EXPECT_EQ(ASCIIToUTF16("fook"), t_urls[0]->keyword());
EXPECT_EQ("foo.com", GetHostFromTemplateURLData(*t_urls[0]));
EXPECT_EQ("foi.com", t_urls[0]->favicon_url.host());
@@ -230,14 +230,14 @@ TEST_F(TemplateURLPrepopulateDataTest, ClearProvidersFromPrefs) {
&default_index);
ASSERT_FALSE(t_urls.empty());
for (size_t i = 0; i < t_urls.size(); ++i) {
- EXPECT_NE(ASCIIToUTF16("foo"), t_urls[i]->short_name);
+ EXPECT_NE(ASCIIToUTF16("foo"), t_urls[i]->short_name());
EXPECT_NE(ASCIIToUTF16("fook"), t_urls[i]->keyword());
EXPECT_NE("foi.com", t_urls[i]->favicon_url.host());
EXPECT_NE("foo.com", GetHostFromTemplateURLData(*t_urls[i]));
EXPECT_NE(1001, t_urls[i]->prepopulate_id);
}
// Ensures the default URL is Google and has the optional fields filled.
- EXPECT_EQ(ASCIIToUTF16("Google"), t_urls[default_index]->short_name);
+ EXPECT_EQ(ASCIIToUTF16("Google"), t_urls[default_index]->short_name());
EXPECT_FALSE(t_urls[default_index]->suggestions_url.empty());
EXPECT_FALSE(t_urls[default_index]->instant_url.empty());
EXPECT_FALSE(t_urls[default_index]->image_url.empty());
@@ -262,7 +262,7 @@ TEST_F(TemplateURLPrepopulateDataTest, ProvidersFromPrepopulated) {
// Ensure all the URLs have the required fields populated.
ASSERT_FALSE(t_urls.empty());
for (size_t i = 0; i < t_urls.size(); ++i) {
- ASSERT_FALSE(t_urls[i]->short_name.empty());
+ ASSERT_FALSE(t_urls[i]->short_name().empty());
ASSERT_FALSE(t_urls[i]->keyword().empty());
ASSERT_FALSE(t_urls[i]->favicon_url.host().empty());
ASSERT_FALSE(GetHostFromTemplateURLData(*t_urls[i]).empty());
@@ -271,7 +271,7 @@ TEST_F(TemplateURLPrepopulateDataTest, ProvidersFromPrepopulated) {
}
// Ensures the default URL is Google and has the optional fields filled.
- EXPECT_EQ(ASCIIToUTF16("Google"), t_urls[default_index]->short_name);
+ EXPECT_EQ(ASCIIToUTF16("Google"), t_urls[default_index]->short_name());
EXPECT_FALSE(t_urls[default_index]->suggestions_url.empty());
EXPECT_FALSE(t_urls[default_index]->instant_url.empty());
EXPECT_FALSE(t_urls[default_index]->image_url.empty());
« no previous file with comments | « components/search_engines/template_url_prepopulate_data.cc ('k') | components/search_engines/template_url_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698