Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more tests that don't set short_name Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/compiler_specific.h" 5 #include "base/compiler_specific.h"
6 #include "base/strings/string16.h" 6 #include "base/strings/string16.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/search_engines/template_url_service_factory_test_util.h " 9 #include "chrome/browser/search_engines/template_url_service_factory_test_util.h "
10 #include "chrome/browser/ui/search_engines/keyword_editor_controller.h" 10 #include "chrome/browser/ui/search_engines/keyword_editor_controller.h"
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 int new_default = controller()->MakeDefaultTemplateURL(index); 235 int new_default = controller()->MakeDefaultTemplateURL(index);
236 EXPECT_EQ(index, new_default); 236 EXPECT_EQ(index, new_default);
237 } 237 }
238 238
239 // Mutates the TemplateURLService and make sure table model is updating 239 // Mutates the TemplateURLService and make sure table model is updating
240 // appropriately. 240 // appropriately.
241 TEST_F(KeywordEditorControllerTest, MutateTemplateURLService) { 241 TEST_F(KeywordEditorControllerTest, MutateTemplateURLService) {
242 int original_row_count = table_model()->RowCount(); 242 int original_row_count = table_model()->RowCount();
243 243
244 TemplateURLData data; 244 TemplateURLData data;
245 data.short_name = ASCIIToUTF16("b"); 245 data.SetShortName(ASCIIToUTF16("b"));
246 data.SetKeyword(ASCIIToUTF16("a")); 246 data.SetKeyword(ASCIIToUTF16("a"));
247 TemplateURL* turl = new TemplateURL(data); 247 TemplateURL* turl = new TemplateURL(data);
248 util()->model()->Add(turl); 248 util()->model()->Add(turl);
249 249
250 // Table model should have updated. 250 // Table model should have updated.
251 VerifyChangeCount(1, 0, 0, 0); 251 VerifyChangeCount(1, 0, 0, 0);
252 252
253 // And should contain the newly added TemplateURL. 253 // And should contain the newly added TemplateURL.
254 ASSERT_EQ(original_row_count + 1, table_model()->RowCount()); 254 ASSERT_EQ(original_row_count + 1, table_model()->RowCount());
255 ASSERT_GE(table_model()->IndexOfTemplateURL(turl), 0); 255 ASSERT_GE(table_model()->IndexOfTemplateURL(turl), 0);
256 } 256 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/search/search_ipc_router_unittest.cc ('k') | chrome/browser/ui/search_engines/search_engine_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698