Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1129853002: Removing FLAG_vector_ics. (Closed)

Created:
5 years, 7 months ago by mvstanton
Modified:
5 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag. BUG= Committed: https://crrev.com/323ced9e272e234d19db13d407b5bb9da266681d Cr-Commit-Position: refs/heads/master@{#28422}

Patch Set 1 #

Patch Set 2 : A few more removals. #

Patch Set 3 : With most ports. #

Patch Set 4 : REBASE. #

Total comments: 4

Patch Set 5 : REBASE and mips ports. #

Patch Set 6 : Comment response. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -1617 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 4 chunks +5 lines, -7 lines 0 comments Download
M src/arm/debug-arm.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 10 chunks +24 lines, -52 lines 0 comments Download
M src/arm/lithium-arm.h View 1 2 3 4 2 chunks +0 lines, -21 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 4 chunks +2 lines, -30 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 4 chunks +5 lines, -7 lines 0 comments Download
M src/arm64/debug-arm64.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 3 4 10 chunks +24 lines, -52 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 2 3 4 2 chunks +0 lines, -21 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 3 4 4 chunks +2 lines, -30 lines 0 comments Download
M src/ast.h View 1 2 3 4 7 chunks +7 lines, -11 lines 0 comments Download
M src/ast-numbering.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M src/builtins.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M src/code-factory.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-factory.cc View 1 2 3 4 3 chunks +2 lines, -13 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 4 chunks +2 lines, -35 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 2 chunks +1 line, -7 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 1 chunk +0 lines, -25 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 3 4 2 chunks +4 lines, -10 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 1 chunk +7 lines, -11 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 3 chunks +21 lines, -28 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 5 chunks +3 lines, -46 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 3 4 2 chunks +0 lines, -17 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 4 chunks +12 lines, -18 lines 0 comments Download
M src/ia32/debug-ia32.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 10 chunks +24 lines, -52 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 4 4 chunks +2 lines, -28 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 3 4 2 chunks +0 lines, -21 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M src/ic/access-compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 2 3 4 5 6 chunks +17 lines, -27 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 2 3 4 5 3 chunks +22 lines, -35 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 2 3 4 5 4 chunks +23 lines, -36 lines 0 comments Download
M src/ic/ic.h View 1 2 3 4 8 chunks +3 lines, -20 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 4 13 chunks +67 lines, -216 lines 0 comments Download
M src/ic/ic-compiler.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 3 chunks +0 lines, -62 lines 0 comments Download
M src/ic/ic-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips/ic-mips.cc View 1 2 3 4 5 6 chunks +17 lines, -26 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 2 3 4 5 6 chunks +17 lines, -26 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 2 3 4 5 4 chunks +23 lines, -35 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 4 chunks +4 lines, -6 lines 0 comments Download
M src/mips/debug-mips.cc View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 3 4 10 chunks +24 lines, -52 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 3 4 4 chunks +2 lines, -31 lines 0 comments Download
M src/mips/lithium-mips.h View 1 2 3 4 2 chunks +0 lines, -21 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 2 3 4 1 chunk +0 lines, -14 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 4 chunks +4 lines, -6 lines 0 comments Download
M src/mips64/debug-mips64.cc View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 2 3 4 10 chunks +24 lines, -52 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 2 3 4 4 chunks +2 lines, -31 lines 0 comments Download
M src/mips64/lithium-mips64.h View 1 2 3 4 2 chunks +0 lines, -21 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 2 3 4 1 chunk +0 lines, -14 lines 0 comments Download
M src/type-feedback-vector.h View 4 chunks +4 lines, -8 lines 0 comments Download
M src/type-feedback-vector.cc View 1 2 3 6 chunks +4 lines, -20 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/typing.cc View 1 chunk +5 lines, -20 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 4 chunks +5 lines, -7 lines 0 comments Download
M src/x64/debug-x64.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 10 chunks +24 lines, -53 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 4 4 chunks +2 lines, -25 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 3 4 2 chunks +0 lines, -22 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 2 5 chunks +5 lines, -16 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 6 chunks +18 lines, -52 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mvstanton
Hi Toon, Here is boilerplate, essentially removing the vector ic flag and much code on ...
5 years, 7 months ago (2015-05-13 14:58:16 UTC) #2
Toon Verwaest
lgtm https://codereview.chromium.org/1129853002/diff/60001/src/ic/arm64/ic-arm64.cc File src/ic/arm64/ic-arm64.cc (right): https://codereview.chromium.org/1129853002/diff/60001/src/ic/arm64/ic-arm64.cc#newcode526 src/ic/arm64/ic-arm64.cc:526: // When vector ics are in use, the ...
5 years, 7 months ago (2015-05-15 09:41:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129853002/100001
5 years, 7 months ago (2015-05-15 13:00:00 UTC) #6
mvstanton
Thanks Toon! --Michael https://codereview.chromium.org/1129853002/diff/60001/src/ic/arm64/ic-arm64.cc File src/ic/arm64/ic-arm64.cc (right): https://codereview.chromium.org/1129853002/diff/60001/src/ic/arm64/ic-arm64.cc#newcode526 src/ic/arm64/ic-arm64.cc:526: // When vector ics are in ...
5 years, 7 months ago (2015-05-15 13:05:28 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-15 13:25:32 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 13:25:52 UTC) #9
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/323ced9e272e234d19db13d407b5bb9da266681d
Cr-Commit-Position: refs/heads/master@{#28422}

Powered by Google App Engine
This is Rietveld 408576698