test/cctest/test-api.cc - Issue 1129853002: Removing FLAG_vector_ics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Comment response. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index e5814d2522770bc9c5ff53dece917e0ab3ea3936..9e9e03a937910963966f923e4bad19aa7d30c2ce 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -15332,9 +15332,6 @@ TEST(ExternalInternalizedStringCollectedAtTearDown) {

TEST(ExternalInternalizedStringCollectedAtGC) {

- // TODO(mvstanton): vector ics need weak support.

- if (i::FLAG_vector_ics) return;

int destroyed = 0;

{ LocalContext env;

v8::HandleScope handle_scope(env->GetIsolate());

« no previous file with comments | « src/x64/lithium-x64.cc ('k') | test/cctest/test-compiler.cc » ('j') | no next file with comments »