Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Side by Side Diff: src/ast-numbering.cc

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment response. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast.h ('k') | src/builtins.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ast.h" 7 #include "src/ast.h"
8 #include "src/ast-numbering.h" 8 #include "src/ast-numbering.h"
9 #include "src/scopes.h" 9 #include "src/scopes.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 13
14 14
15 class AstNumberingVisitor final : public AstVisitor { 15 class AstNumberingVisitor final : public AstVisitor {
16 public: 16 public:
17 explicit AstNumberingVisitor(Isolate* isolate, Zone* zone) 17 explicit AstNumberingVisitor(Isolate* isolate, Zone* zone)
18 : AstVisitor(), 18 : AstVisitor(),
19 next_id_(BailoutId::FirstUsable().ToInt()), 19 next_id_(BailoutId::FirstUsable().ToInt()),
20 properties_(zone), 20 properties_(zone),
21 ic_slot_cache_(FLAG_vector_ics ? 4 : 0), 21 ic_slot_cache_(4),
22 dont_optimize_reason_(kNoReason) { 22 dont_optimize_reason_(kNoReason) {
23 InitializeAstVisitor(isolate, zone); 23 InitializeAstVisitor(isolate, zone);
24 } 24 }
25 25
26 bool Renumber(FunctionLiteral* node); 26 bool Renumber(FunctionLiteral* node);
27 27
28 private: 28 private:
29 // AST node visitor interface. 29 // AST node visitor interface.
30 #define DEFINE_VISIT(type) virtual void Visit##type(type* node) override; 30 #define DEFINE_VISIT(type) virtual void Visit##type(type* node) override;
31 AST_NODE_LIST(DEFINE_VISIT) 31 AST_NODE_LIST(DEFINE_VISIT)
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 node->ComputeFeedbackRequirements(isolate(), &ic_slot_cache_); 64 node->ComputeFeedbackRequirements(isolate(), &ic_slot_cache_);
65 if (reqs.slots() > 0) { 65 if (reqs.slots() > 0) {
66 node->SetFirstFeedbackSlot(FeedbackVectorSlot(properties_.slots())); 66 node->SetFirstFeedbackSlot(FeedbackVectorSlot(properties_.slots()));
67 properties_.increase_slots(reqs.slots()); 67 properties_.increase_slots(reqs.slots());
68 } 68 }
69 if (reqs.ic_slots() > 0) { 69 if (reqs.ic_slots() > 0) {
70 int ic_slots = properties_.ic_slots(); 70 int ic_slots = properties_.ic_slots();
71 node->SetFirstFeedbackICSlot(FeedbackVectorICSlot(ic_slots), 71 node->SetFirstFeedbackICSlot(FeedbackVectorICSlot(ic_slots),
72 &ic_slot_cache_); 72 &ic_slot_cache_);
73 properties_.increase_ic_slots(reqs.ic_slots()); 73 properties_.increase_ic_slots(reqs.ic_slots());
74 if (FLAG_vector_ics) { 74 for (int i = 0; i < reqs.ic_slots(); i++) {
75 for (int i = 0; i < reqs.ic_slots(); i++) { 75 properties_.SetKind(ic_slots + i, node->FeedbackICSlotKind(i));
76 properties_.SetKind(ic_slots + i, node->FeedbackICSlotKind(i));
77 }
78 } 76 }
79 } 77 }
80 } 78 }
81 79
82 BailoutReason dont_optimize_reason() const { return dont_optimize_reason_; } 80 BailoutReason dont_optimize_reason() const { return dont_optimize_reason_; }
83 81
84 int next_id_; 82 int next_id_;
85 AstProperties properties_; 83 AstProperties properties_;
86 // The slot cache allows us to reuse certain vector IC slots. It's only used 84 // The slot cache allows us to reuse certain vector IC slots.
87 // if FLAG_vector_ics is true.
88 ICSlotCache ic_slot_cache_; 85 ICSlotCache ic_slot_cache_;
89 BailoutReason dont_optimize_reason_; 86 BailoutReason dont_optimize_reason_;
90 87
91 DEFINE_AST_VISITOR_SUBCLASS_MEMBERS(); 88 DEFINE_AST_VISITOR_SUBCLASS_MEMBERS();
92 DISALLOW_COPY_AND_ASSIGN(AstNumberingVisitor); 89 DISALLOW_COPY_AND_ASSIGN(AstNumberingVisitor);
93 }; 90 };
94 91
95 92
96 void AstNumberingVisitor::VisitVariableDeclaration(VariableDeclaration* node) { 93 void AstNumberingVisitor::VisitVariableDeclaration(VariableDeclaration* node) {
97 IncrementNodeCount(); 94 IncrementNodeCount();
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 } 521 }
525 522
526 523
527 bool AstNumbering::Renumber(Isolate* isolate, Zone* zone, 524 bool AstNumbering::Renumber(Isolate* isolate, Zone* zone,
528 FunctionLiteral* function) { 525 FunctionLiteral* function) {
529 AstNumberingVisitor visitor(isolate, zone); 526 AstNumberingVisitor visitor(isolate, zone);
530 return visitor.Renumber(function); 527 return visitor.Renumber(function);
531 } 528 }
532 } 529 }
533 } // namespace v8::internal 530 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/builtins.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698