Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: src/x64/debug-x64.cc

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment response. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 // -- rdi : function 156 // -- rdi : function
157 // ----------------------------------- 157 // -----------------------------------
158 Generate_DebugBreakCallHelper(masm, rdx.bit() | rdi.bit(), 0, false); 158 Generate_DebugBreakCallHelper(masm, rdx.bit() | rdi.bit(), 0, false);
159 } 159 }
160 160
161 161
162 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) { 162 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) {
163 // Register state for IC load call (from ic-x64.cc). 163 // Register state for IC load call (from ic-x64.cc).
164 Register receiver = LoadDescriptor::ReceiverRegister(); 164 Register receiver = LoadDescriptor::ReceiverRegister();
165 Register name = LoadDescriptor::NameRegister(); 165 Register name = LoadDescriptor::NameRegister();
166 RegList regs = receiver.bit() | name.bit(); 166 RegList regs = receiver.bit() | name.bit() |
167 if (FLAG_vector_ics) { 167 VectorLoadICTrampolineDescriptor::SlotRegister().bit();
168 regs |= VectorLoadICTrampolineDescriptor::SlotRegister().bit();
169 }
170 Generate_DebugBreakCallHelper(masm, regs, 0, false); 168 Generate_DebugBreakCallHelper(masm, regs, 0, false);
171 } 169 }
172 170
173 171
174 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) { 172 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
175 // Register state for IC store call (from ic-x64.cc). 173 // Register state for IC store call (from ic-x64.cc).
176 Register receiver = StoreDescriptor::ReceiverRegister(); 174 Register receiver = StoreDescriptor::ReceiverRegister();
177 Register name = StoreDescriptor::NameRegister(); 175 Register name = StoreDescriptor::NameRegister();
178 Register value = StoreDescriptor::ValueRegister(); 176 Register value = StoreDescriptor::ValueRegister();
179 Generate_DebugBreakCallHelper( 177 Generate_DebugBreakCallHelper(
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 __ jmp(rdx); 298 __ jmp(rdx);
301 } 299 }
302 300
303 const bool LiveEdit::kFrameDropperSupported = true; 301 const bool LiveEdit::kFrameDropperSupported = true;
304 302
305 #undef __ 303 #undef __
306 304
307 } } // namespace v8::internal 305 } } // namespace v8::internal
308 306
309 #endif // V8_TARGET_ARCH_X64 307 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698