Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: src/code-factory.cc

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment response. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-factory.cc
diff --git a/src/code-factory.cc b/src/code-factory.cc
index 8e244604c2e3f19dc91e69e6f69645920f761a3d..cbfce3d5a9100b1b1f576f13229e1438015d014f 100644
--- a/src/code-factory.cc
+++ b/src/code-factory.cc
@@ -11,14 +11,6 @@
namespace v8 {
namespace internal {
-// static
-Callable CodeFactory::LoadGlobalIC(Isolate* isolate,
- Handle<GlobalObject> global,
- Handle<String> name) {
- return Callable(LoadIC::load_global(isolate, global, name),
- LoadDescriptor(isolate));
-}
-
// static
Callable CodeFactory::LoadIC(Isolate* isolate, ContextualMode mode) {
@@ -34,10 +26,7 @@ Callable CodeFactory::LoadICInOptimizedCode(
InlineCacheState initialization_state) {
auto code = LoadIC::initialize_stub_in_optimized_code(
isolate, LoadICState(mode).GetExtraICState(), initialization_state);
- if (FLAG_vector_ics) {
- return Callable(code, VectorLoadICDescriptor(isolate));
- }
- return Callable(code, LoadDescriptor(isolate));
+ return Callable(code, VectorLoadICDescriptor(isolate));
}
@@ -53,7 +42,7 @@ Callable CodeFactory::KeyedLoadICInOptimizedCode(
Isolate* isolate, InlineCacheState initialization_state) {
auto code = KeyedLoadIC::initialize_stub_in_optimized_code(
isolate, initialization_state);
- if (FLAG_vector_ics && initialization_state != MEGAMORPHIC) {
+ if (initialization_state != MEGAMORPHIC) {
return Callable(code, VectorLoadICDescriptor(isolate));
}
return Callable(code, LoadDescriptor(isolate));
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698