Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/compiler/js-generic-lowering.cc

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment response. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-factory.h" 5 #include "src/code-factory.h"
6 #include "src/code-stubs.h" 6 #include "src/code-stubs.h"
7 #include "src/compiler/common-operator.h" 7 #include "src/compiler/common-operator.h"
8 #include "src/compiler/js-generic-lowering.h" 8 #include "src/compiler/js-generic-lowering.h"
9 #include "src/compiler/js-graph.h" 9 #include "src/compiler/js-graph.h"
10 #include "src/compiler/machine-operator.h" 10 #include "src/compiler/machine-operator.h"
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 void JSGenericLowering::LowerJSToObject(Node* node) { 336 void JSGenericLowering::LowerJSToObject(Node* node) {
337 ReplaceWithBuiltinCall(node, Builtins::TO_OBJECT, 1); 337 ReplaceWithBuiltinCall(node, Builtins::TO_OBJECT, 1);
338 } 338 }
339 339
340 340
341 void JSGenericLowering::LowerJSLoadProperty(Node* node) { 341 void JSGenericLowering::LowerJSLoadProperty(Node* node) {
342 CallDescriptor::Flags flags = AdjustFrameStatesForCall(node); 342 CallDescriptor::Flags flags = AdjustFrameStatesForCall(node);
343 const LoadPropertyParameters& p = LoadPropertyParametersOf(node->op()); 343 const LoadPropertyParameters& p = LoadPropertyParametersOf(node->op());
344 Callable callable = 344 Callable callable =
345 CodeFactory::KeyedLoadICInOptimizedCode(isolate(), UNINITIALIZED); 345 CodeFactory::KeyedLoadICInOptimizedCode(isolate(), UNINITIALIZED);
346 if (FLAG_vector_ics) { 346 node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index()));
347 node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index())); 347 node->InsertInput(zone(), 3, jsgraph()->HeapConstant(p.feedback().vector()));
348 node->InsertInput(zone(), 3,
349 jsgraph()->HeapConstant(p.feedback().vector()));
350 }
351 ReplaceWithStubCall(node, callable, 348 ReplaceWithStubCall(node, callable,
352 CallDescriptor::kPatchableCallSite | flags); 349 CallDescriptor::kPatchableCallSite | flags);
353 } 350 }
354 351
355 352
356 void JSGenericLowering::LowerJSLoadNamed(Node* node) { 353 void JSGenericLowering::LowerJSLoadNamed(Node* node) {
357 CallDescriptor::Flags flags = AdjustFrameStatesForCall(node); 354 CallDescriptor::Flags flags = AdjustFrameStatesForCall(node);
358 const LoadNamedParameters& p = LoadNamedParametersOf(node->op()); 355 const LoadNamedParameters& p = LoadNamedParametersOf(node->op());
359 Callable callable = 356 Callable callable =
360 p.load_ic() == NAMED 357 p.load_ic() == NAMED
361 ? CodeFactory::LoadICInOptimizedCode(isolate(), p.contextual_mode(), 358 ? CodeFactory::LoadICInOptimizedCode(isolate(), p.contextual_mode(),
362 UNINITIALIZED) 359 UNINITIALIZED)
363 : CodeFactory::KeyedLoadICInOptimizedCode(isolate(), UNINITIALIZED); 360 : CodeFactory::KeyedLoadICInOptimizedCode(isolate(), UNINITIALIZED);
364 node->InsertInput(zone(), 1, jsgraph()->HeapConstant(p.name())); 361 node->InsertInput(zone(), 1, jsgraph()->HeapConstant(p.name()));
365 if (FLAG_vector_ics) { 362 node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index()));
366 node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index())); 363 node->InsertInput(zone(), 3, jsgraph()->HeapConstant(p.feedback().vector()));
367 node->InsertInput(zone(), 3,
368 jsgraph()->HeapConstant(p.feedback().vector()));
369 }
370 ReplaceWithStubCall(node, callable, 364 ReplaceWithStubCall(node, callable,
371 CallDescriptor::kPatchableCallSite | flags); 365 CallDescriptor::kPatchableCallSite | flags);
372 } 366 }
373 367
374 368
375 void JSGenericLowering::LowerJSStoreProperty(Node* node) { 369 void JSGenericLowering::LowerJSStoreProperty(Node* node) {
376 CallDescriptor::Flags flags = AdjustFrameStatesForCall(node); 370 CallDescriptor::Flags flags = AdjustFrameStatesForCall(node);
377 LanguageMode language_mode = OpParameter<LanguageMode>(node); 371 LanguageMode language_mode = OpParameter<LanguageMode>(node);
378 Callable callable = CodeFactory::KeyedStoreICInOptimizedCode( 372 Callable callable = CodeFactory::KeyedStoreICInOptimizedCode(
379 isolate(), language_mode, UNINITIALIZED); 373 isolate(), language_mode, UNINITIALIZED);
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
618 } 612 }
619 613
620 614
621 MachineOperatorBuilder* JSGenericLowering::machine() const { 615 MachineOperatorBuilder* JSGenericLowering::machine() const {
622 return jsgraph()->machine(); 616 return jsgraph()->machine();
623 } 617 }
624 618
625 } // namespace compiler 619 } // namespace compiler
626 } // namespace internal 620 } // namespace internal
627 } // namespace v8 621 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698