Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: src/ast.h

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment response. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/ast-numbering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast.h
diff --git a/src/ast.h b/src/ast.h
index 31bfca67d157c94dcae3d9a73044ade457f66d64..26950b4c9ae95ca003e177422e45e41130e63691 100644
--- a/src/ast.h
+++ b/src/ast.h
@@ -1592,7 +1592,7 @@ class VariableProxy final : public Expression {
void BindTo(Variable* var);
bool UsesVariableFeedbackSlot() const {
- return FLAG_vector_ics && (var()->IsUnallocated() || var()->IsLookupSlot());
+ return var()->IsUnallocated() || var()->IsLookupSlot();
}
virtual FeedbackVectorRequirements ComputeFeedbackRequirements(
@@ -1691,7 +1691,7 @@ class Property final : public Expression {
virtual FeedbackVectorRequirements ComputeFeedbackRequirements(
Isolate* isolate, const ICSlotCache* cache) override {
- return FeedbackVectorRequirements(0, FLAG_vector_ics ? 1 : 0);
+ return FeedbackVectorRequirements(0, 1);
}
void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot,
ICSlotCache* cache) override {
@@ -1702,7 +1702,7 @@ class Property final : public Expression {
}
FeedbackVectorICSlot PropertyFeedbackSlot() const {
- DCHECK(!FLAG_vector_ics || !property_feedback_slot_.IsInvalid());
+ DCHECK(!property_feedback_slot_.IsInvalid());
return property_feedback_slot_;
}
@@ -1939,9 +1939,7 @@ class CallRuntime final : public Expression {
bool is_jsruntime() const { return function_ == NULL; }
// Type feedback information.
- bool HasCallRuntimeFeedbackSlot() const {
- return FLAG_vector_ics && is_jsruntime();
- }
+ bool HasCallRuntimeFeedbackSlot() const { return is_jsruntime(); }
virtual FeedbackVectorRequirements ComputeFeedbackRequirements(
Isolate* isolate, const ICSlotCache* cache) override {
return FeedbackVectorRequirements(0, HasCallRuntimeFeedbackSlot() ? 1 : 0);
@@ -2331,9 +2329,7 @@ class Yield final : public Expression {
}
// Type feedback information.
- bool HasFeedbackSlots() const {
- return FLAG_vector_ics && (yield_kind() == kDelegating);
- }
+ bool HasFeedbackSlots() const { return yield_kind() == kDelegating; }
virtual FeedbackVectorRequirements ComputeFeedbackRequirements(
Isolate* isolate, const ICSlotCache* cache) override {
return FeedbackVectorRequirements(0, HasFeedbackSlots() ? 3 : 0);
@@ -2691,7 +2687,7 @@ class SuperReference final : public Expression {
// Type feedback information.
virtual FeedbackVectorRequirements ComputeFeedbackRequirements(
Isolate* isolate, const ICSlotCache* cache) override {
- return FeedbackVectorRequirements(0, FLAG_vector_ics ? 1 : 0);
+ return FeedbackVectorRequirements(0, 1);
}
void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot,
ICSlotCache* cache) override {
@@ -2700,7 +2696,7 @@ class SuperReference final : public Expression {
Code::Kind FeedbackICSlotKind(int index) override { return Code::LOAD_IC; }
FeedbackVectorICSlot HomeObjectFeedbackSlot() {
- DCHECK(!FLAG_vector_ics || !homeobject_feedback_slot_.IsInvalid());
+ DCHECK(!homeobject_feedback_slot_.IsInvalid());
return homeobject_feedback_slot_;
}
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/ast-numbering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698