test/cctest/test-compiler.cc - Issue 1129853002: Removing FLAG_vector_ics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-compiler.cc

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Comment response. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-compiler.cc

diff --git a/test/cctest/test-compiler.cc b/test/cctest/test-compiler.cc

index ed8b1c6d998c0d1f8aabc172d73ba3f9da1d87ab..32c153ce79280b3d503c46a93cbddb52286bd777 100644

--- a/test/cctest/test-compiler.cc

+++ b/test/cctest/test-compiler.cc

@@ -362,7 +362,7 @@ TEST(FeedbackVectorUnaffectedByScopeChanges) {

// Now a feedback vector is allocated.

CHECK(f->shared()->is_compiled());

int expected_slots = 0;

- int expected_ic_slots = FLAG_vector_ics ? 2 : 1;

+ int expected_ic_slots = 2;

CHECK_EQ(expected_slots, f->shared()->feedback_vector()->Slots());

CHECK_EQ(expected_ic_slots, f->shared()->feedback_vector()->ICSlots());

}

« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-feedback-vector.cc » ('j') | no next file with comments »