Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Kill PageTest.DidRunActions hook. This can be merged to ValidateAndMeasurePage method. BUG=455391, 470147 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/7e0ecde0378db4165a8b146deb0e00c69564aa27 Cr-Commit-Position: refs/heads/master@{#329468}

Patch Set 1 #

Patch Set 2 : fix unittest #

Patch Set 3 : rebase #

Patch Set 4 : Fix unittest #

Patch Set 5 : Fix task_execution_time. Thanks unittest! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -46 lines) Patch
M tools/perf/measurements/oilpan_gc_times.py View 1 2 3 4 chunks +9 lines, -10 lines 0 comments Download
M tools/perf/measurements/oilpan_gc_times_unittest.py View 1 2 3 4 chunks +15 lines, -5 lines 0 comments Download
M tools/perf/measurements/task_execution_time.py View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/task_execution_time_unittest.py View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/measurements/v8_gc_times.py View 2 chunks +3 lines, -7 lines 0 comments Download
M tools/perf/measurements/v8_gc_times_unittest.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
nednguyen
5 years, 7 months ago (2015-05-11 21:05:09 UTC) #2
sullivan
lgtm
5 years, 7 months ago (2015-05-11 21:08:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124033004/20001
5 years, 7 months ago (2015-05-11 21:16:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/63506)
5 years, 7 months ago (2015-05-11 22:41:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124033004/40001
5 years, 7 months ago (2015-05-12 02:49:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/63677)
5 years, 7 months ago (2015-05-12 04:03:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124033004/80001
5 years, 7 months ago (2015-05-12 15:33:11 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/21927)
5 years, 7 months ago (2015-05-12 17:31:40 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124033004/100001
5 years, 7 months ago (2015-05-12 17:44:28 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
5 years, 7 months ago (2015-05-12 19:47:19 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124033004/100001
5 years, 7 months ago (2015-05-12 19:50:39 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 7 months ago (2015-05-12 19:59:36 UTC) #27
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 20:01:10 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7e0ecde0378db4165a8b146deb0e00c69564aa27
Cr-Commit-Position: refs/heads/master@{#329468}

Powered by Google App Engine
This is Rietveld 408576698