tools/perf/measurements/v8_gc_times_unittest.py - Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/v8_gc_times_unittest.py

Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix task_execution_time. Thanks unittest! Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/v8_gc_times_unittest.py

diff --git a/tools/perf/measurements/v8_gc_times_unittest.py b/tools/perf/measurements/v8_gc_times_unittest.py

index 921227701015ec14191fe5943d4656a7cee0ceff..aaf816bd6bf5c0bd171f7e6098bec58fad9a482b 100644

--- a/tools/perf/measurements/v8_gc_times_unittest.py

+++ b/tools/perf/measurements/v8_gc_times_unittest.py

@@ -53,7 +53,8 @@ class V8GCTimesTestPageHelper(object):

self._model.FinalizeImport()

# Measure the V8GCTimes metric and return the results

- v8_gc_times_metric.ValidateAndMeasurePage(page, None, results)

+ # pylint: disable=protected-access

+ v8_gc_times_metric._AddV8MetricsToResults(self._renderer_process, results)

results.DidRunPage(page)

return results

« no previous file with comments | « tools/perf/measurements/v8_gc_times.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »