Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: tools/perf/measurements/v8_gc_times_unittest.py

Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix task_execution_time. Thanks unittest! Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/measurements/v8_gc_times.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.core import wpr_modes 5 from telemetry.core import wpr_modes
6 from telemetry.page import page as page_module 6 from telemetry.page import page as page_module
7 from telemetry.results import page_test_results 7 from telemetry.results import page_test_results
8 from telemetry.timeline import model as model_module 8 from telemetry.timeline import model as model_module
9 from telemetry.unittest_util import options_for_unittests 9 from telemetry.unittest_util import options_for_unittests
10 from telemetry.unittest_util import page_test_test_case 10 from telemetry.unittest_util import page_test_test_case
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 results.WillRunPage(page) 46 results.WillRunPage(page)
47 47
48 v8_gc_times_metric = v8_gc_times.V8GCTimes() 48 v8_gc_times_metric = v8_gc_times.V8GCTimes()
49 # pylint: disable=protected-access 49 # pylint: disable=protected-access
50 v8_gc_times_metric._renderer_process = self._renderer_process 50 v8_gc_times_metric._renderer_process = self._renderer_process
51 51
52 # Finalize the timeline import. 52 # Finalize the timeline import.
53 self._model.FinalizeImport() 53 self._model.FinalizeImport()
54 54
55 # Measure the V8GCTimes metric and return the results 55 # Measure the V8GCTimes metric and return the results
56 v8_gc_times_metric.ValidateAndMeasurePage(page, None, results) 56 # pylint: disable=protected-access
57 v8_gc_times_metric._AddV8MetricsToResults(self._renderer_process, results)
57 results.DidRunPage(page) 58 results.DidRunPage(page)
58 return results 59 return results
59 60
60 61
61 class V8GCTimesTests(page_test_test_case.PageTestTestCase): 62 class V8GCTimesTests(page_test_test_case.PageTestTestCase):
62 63
63 def setUp(self): 64 def setUp(self):
64 self._options = options_for_unittests.GetCopy() 65 self._options = options_for_unittests.GetCopy()
65 self._options.browser_options.wpr_mode = wpr_modes.WPR_OFF 66 self._options.browser_options.wpr_mode = wpr_modes.WPR_OFF
66 67
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 'v8_gc_mark_compactor_idle_deadline_overrun': ('ms', 0.0), 257 'v8_gc_mark_compactor_idle_deadline_overrun': ('ms', 0.0),
257 'v8_gc_mark_compactor_outside_idle': ('ms', 0.0), 258 'v8_gc_mark_compactor_outside_idle': ('ms', 0.0),
258 'v8_gc_mark_compactor_percentage_idle': ('idle%', 0.0), 259 'v8_gc_mark_compactor_percentage_idle': ('idle%', 0.0),
259 'v8_gc_scavenger': ('ms', 0.0), 260 'v8_gc_scavenger': ('ms', 0.0),
260 'v8_gc_scavenger_idle_deadline_overrun': ('ms', 0.0), 261 'v8_gc_scavenger_idle_deadline_overrun': ('ms', 0.0),
261 'v8_gc_scavenger_outside_idle': ('ms', 0.0), 262 'v8_gc_scavenger_outside_idle': ('ms', 0.0),
262 'v8_gc_scavenger_percentage_idle': ('idle%', 0.0), 263 'v8_gc_scavenger_percentage_idle': ('idle%', 0.0),
263 'v8_gc_total': ('ms', 0.0), 264 'v8_gc_total': ('ms', 0.0),
264 'v8_gc_total_idle_deadline_overrun': ('ms', 0.0), 265 'v8_gc_total_idle_deadline_overrun': ('ms', 0.0),
265 'v8_gc_total_outside_idle': ('ms', 0.0)} 266 'v8_gc_total_outside_idle': ('ms', 0.0)}
OLDNEW
« no previous file with comments | « tools/perf/measurements/v8_gc_times.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698