Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: tools/perf/measurements/v8_gc_times.py

Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix task_execution_time. Thanks unittest! Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/v8_gc_times.py
diff --git a/tools/perf/measurements/v8_gc_times.py b/tools/perf/measurements/v8_gc_times.py
index ebb36f405d3da7fbc802dcf6fe1f1907bb1dcd12..01e2d0175848f9f9e3ff0cf3e0393d1b58c95562 100644
--- a/tools/perf/measurements/v8_gc_times.py
+++ b/tools/perf/measurements/v8_gc_times.py
@@ -23,7 +23,6 @@ class V8GCTimes(page_test.PageTest):
def __init__(self):
super(V8GCTimes, self).__init__()
- self._renderer_process = None
def WillNavigateToPage(self, page, tab):
category_filter = tracing_category_filter.TracingCategoryFilter()
@@ -37,14 +36,11 @@ class V8GCTimes(page_test.PageTest):
tab.browser.platform.tracing_controller.Start(
options, category_filter, self._TIME_OUT_IN_SECONDS)
- def DidRunActions(self, page, tab):
+ def ValidateAndMeasurePage(self, page, tab, results):
trace_data = tab.browser.platform.tracing_controller.Stop()
timeline_model = TimelineModel(trace_data)
-
- self._renderer_process = timeline_model.GetRendererProcessFromTabId(tab.id)
-
- def ValidateAndMeasurePage(self, page, tab, results):
- self._AddV8MetricsToResults(self._renderer_process, results)
+ renderer_process = timeline_model.GetRendererProcessFromTabId(tab.id)
+ self._AddV8MetricsToResults(renderer_process, results)
def _AddV8MetricsToResults(self, process, results):
if process is None:
« no previous file with comments | « tools/perf/measurements/task_execution_time_unittest.py ('k') | tools/perf/measurements/v8_gc_times_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698