[Telemetry] Kill PageTest.DidRunActions hook.

tools/perf/measurements/oilpan_gc_times_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from measurements import oilpan_gc_times
 
+from telemetry.core import util
 from telemetry.results import page_test_results
 from telemetry.timeline import model
 from telemetry.timeline import slice as slice_data
 from telemetry.unittest_util import options_for_unittests
 from telemetry.unittest_util import page_test_test_case
 from telemetry.page import page as page_module
 
+util.AddDirToPythonPath(util.GetTelemetryDir(), 'third_party', 'mock')
+import mock  # pylint: disable=import-error
+
 
 class TestOilpanGCTimesPage(page_module.Page):
   def __init__(self, page_set):
     super(TestOilpanGCTimesPage, self).__init__(
         'file://blank.html', page_set, page_set.base_dir)
 
   def RunPageInteractions(self, action_runner):
     with action_runner.CreateGestureInteraction('ScrollAction'):
       action_runner.ScrollPage()
 
@@ skipping 59 matching lines @@
   # pylint: disable=protected-access
   def testForParsingOldFormat(self):
     def getMetric(results, name):
       metrics = results.FindAllPageSpecificValuesNamed(name)
       self.assertEquals(1, len(metrics))
       return metrics[0].GetBuildbotValue()
 
     data = self._GenerateDataForParsingOldFormat()
 
     measurement = oilpan_gc_times._OilpanGCTimesBase()
-    measurement._renderer_process = data._renderer_process
-    measurement._timeline_model = data._model
-    measurement.ValidateAndMeasurePage(None, None, data.results)
+
+    tab = mock.MagicMock()
+    with mock.patch(
+        'measurements.oilpan_gc_times.TimelineModel') as MockTimelineModel:
+      MockTimelineModel.return_value = data._model
+      measurement.ValidateAndMeasurePage(None, tab, data.results)
 
     results = data.results
     self.assertEquals(7, len(getMetric(results, 'oilpan_coalesce')))
     self.assertEquals(3, len(getMetric(results, 'oilpan_precise_mark')))
     self.assertEquals(3, len(getMetric(results, 'oilpan_precise_lazy_sweep')))
     self.assertEquals(3, len(getMetric(results,
                                        'oilpan_precise_complete_sweep')))
     self.assertEquals(1, len(getMetric(results, 'oilpan_conservative_mark')))
     self.assertEquals(1, len(getMetric(results,
                                        'oilpan_conservative_lazy_sweep')))
     self.assertEquals(1, len(getMetric(results,
                                        'oilpan_conservative_complete_sweep')))
     self.assertEquals(2, len(getMetric(results, 'oilpan_forced_mark')))
     self.assertEquals(2, len(getMetric(results, 'oilpan_forced_lazy_sweep')))
     self.assertEquals(2, len(getMetric(results,
                                        'oilpan_forced_complete_sweep')))
 
   # Disable for accessing private API of _OilpanGCTimesBase.
   # pylint: disable=protected-access
   def testForParsing(self):
     def getMetric(results, name):
       metrics = results.FindAllPageSpecificValuesNamed(name)
       self.assertEquals(1, len(metrics))
       return metrics[0].GetBuildbotValue()
 
     data = self._GenerateDataForParsing()
 
     measurement = oilpan_gc_times._OilpanGCTimesBase()
-    measurement._renderer_process = data._renderer_process
     measurement._timeline_model = data._model
-    measurement.ValidateAndMeasurePage(None, None, data.results)
+    tab = mock.MagicMock()
+    with mock.patch(
+        'measurements.oilpan_gc_times.TimelineModel') as MockTimelineModel:
+      MockTimelineModel.return_value = data._model
+      measurement.ValidateAndMeasurePage(None, tab, data.results)
 
     results = data.results
     self.assertEquals(8, len(getMetric(results, 'oilpan_coalesce')))
     self.assertEquals(4, len(getMetric(results, 'oilpan_precise_mark')))
     self.assertEquals(4, len(getMetric(results, 'oilpan_precise_lazy_sweep')))
     self.assertEquals(4, len(getMetric(results,
                                        'oilpan_precise_complete_sweep')))
     self.assertEquals(4, len(getMetric(results, 'oilpan_conservative_mark')))
     self.assertEquals(4, len(getMetric(results,
                                        'oilpan_conservative_lazy_sweep')))
@@ skipping 130 matching lines @@
     data.AddSlice(self._KEY_COMPLETE_SWEEP, 862, 42, {})
     data.AddSlice(self._KEY_MARK, 904, 43,
                   {'lazySweeping': False, 'gcReason': 'IdleGC'})
     last_measure = data.AddSlice(self._KEY_COMPLETE_SWEEP, 947, 44, {})
 
     # Async event
     async_dur = last_measure.end - first_measure.start
     data.AddAsyncSlice(self._KEY_MEASURE, first_measure.start, async_dur, {})
 
     return data