Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix task_execution_time. Thanks unittest! Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/v8_gc_times_unittest.py ('k') | tools/telemetry/telemetry/page/record_wpr.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_test.py
diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py
index 2d57dcbc621639d1b1973f950ded113db8e423f7..a1588a8f54555525f992ed1c8805f52c6e917e02 100644
--- a/tools/telemetry/telemetry/page/page_test.py
+++ b/tools/telemetry/telemetry/page/page_test.py
@@ -160,9 +160,6 @@ class PageTest(object):
"""Override to do operations right after the page is navigated and after
all waiting for completion has occurred."""
- def DidRunActions(self, page, tab):
- """Override to do operations after running the actions on the page."""
-
def CleanUpAfterPage(self, page, tab):
"""Called after the test run method was run, even if it failed."""
@@ -207,7 +204,6 @@ class PageTest(object):
action_runner = action_runner_module.ActionRunner(
tab, skip_waits=page.skip_waits)
page.RunPageInteractions(action_runner)
- self.DidRunActions(page, tab)
self.ValidateAndMeasurePage(page, tab, results)
def RunNavigateSteps(self, page, tab):
« no previous file with comments | « tools/perf/measurements/v8_gc_times_unittest.py ('k') | tools/telemetry/telemetry/page/record_wpr.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698