Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: tools/telemetry/telemetry/page/record_wpr_unittest.py

Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix task_execution_time. Thanks unittest! Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/record_wpr_unittest.py
diff --git a/tools/telemetry/telemetry/page/record_wpr_unittest.py b/tools/telemetry/telemetry/page/record_wpr_unittest.py
index b51f743cb69a7e7c5bd5575e2c97a7562d5a1931..367461ced1b928243375ce37083e9a0b6981809b 100644
--- a/tools/telemetry/telemetry/page/record_wpr_unittest.py
+++ b/tools/telemetry/telemetry/page/record_wpr_unittest.py
@@ -55,9 +55,6 @@ class MockPageTest(page_test.PageTest):
def DidNavigateToPage(self, page, tab):
self.func_calls.append('DidNavigateToPage')
- def DidRunActions(self, page, tab):
- self.func_calls.append('DidRunActions')
-
def ValidateAndMeasurePage(self, page, tab, results):
self.func_calls.append('ValidateAndMeasurePage')
@@ -121,10 +118,9 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):
record_page_test.page_test = MockBenchmark().test()
page = MockPage(page_set=MockPageSet(url=self._url), url=self._url)
record_page_test.RunPage(page, self._tab, results=None)
- self.assertEqual(2, len(record_page_test.page_test.func_calls))
- self.assertEqual('DidRunActions', record_page_test.page_test.func_calls[0])
+ self.assertEqual(1, len(record_page_test.page_test.func_calls))
self.assertEqual('ValidateAndMeasurePage',
- record_page_test.page_test.func_calls[1])
+ record_page_test.page_test.func_calls[0])
@decorators.Disabled('chromeos') # crbug.com/404868.
def testWprRecorderWithPageSet(self):
« no previous file with comments | « tools/telemetry/telemetry/page/record_wpr.py ('k') | tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698