tools/perf/measurements/task_execution_time_unittest.py - Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/task_execution_time_unittest.py

Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix task_execution_time. Thanks unittest! Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/task_execution_time_unittest.py

diff --git a/tools/perf/measurements/task_execution_time_unittest.py b/tools/perf/measurements/task_execution_time_unittest.py

index 8a7631248f44e865fe7a2346a740eea0c80583f2..38163fd764f80b04f9f3cd08112d6f97a355a3da 100644

--- a/tools/perf/measurements/task_execution_time_unittest.py

+++ b/tools/perf/measurements/task_execution_time_unittest.py

@@ -161,7 +161,7 @@ class TaskExecutionTimeUnitTest(page_test_test_case.PageTestTestCase):

data.AddSlice('task' + str(duration), 0, duration)

# Run the code we are testing.

- self._measurement.ValidateAndMeasurePage(None, None, data.results)

+ self._measurement._AddResults(data.results)

# Check that the last (i.e. biggest) _NUMBER_OF_RESULTS_TO_DISPLAY get

# returned in the results.

@@ -187,7 +187,7 @@ class TaskExecutionTimeUnitTest(page_test_test_case.PageTestTestCase):

data.AddSlice('slow', 0, 1000)

# Run the code we are testing and return results.

- self._measurement.ValidateAndMeasurePage(None, None, data.results)

+ self._measurement._AddResults(data.results)

return data

def _GenerateResultsFromMockedIdleData(self):

@@ -217,7 +217,7 @@ class TaskExecutionTimeUnitTest(page_test_test_case.PageTestTestCase):

data.AddSlice('not_idle', slice_start_time, fast_slice_duration)

# Run the code we are testing.

- self._measurement.ValidateAndMeasurePage(None, None, data.results)

+ self._measurement._AddResults(data.results)

return data