tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py - Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py

Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix task_execution_time. Thanks unittest! Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py b/tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py

index 71c0d977ad28de2130824aa499e614ea068d5adb..aa23b25a5b94ba4da467599c35b5a2053ed8bd52 100644

--- a/tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py

@@ -130,14 +130,11 @@ class SmoothGestureTest(page_test_test_case.PageTestTestCase):

tab.browser.platform.tracing_controller.Start(

options, tracing_category_filter.TracingCategoryFilter())

- def DidRunActions(self, _page, tab):

+ def ValidateAndMeasurePage(self, _page, tab, _results):

models.append(model_module.TimelineModel(

tab.browser.platform.tracing_controller.Stop()))

tab_ids.append(tab.id)

- def ValidateAndMeasurePage(self, _page, _tab, _results):

- pass

self.RunMeasurement(ScrollingGestureTestMeasurement(), ps)

timeline_model = models[0]

renderer_thread = timeline_model.GetRendererThreadFromTabId(

« no previous file with comments | « tools/telemetry/telemetry/page/record_wpr_unittest.py ('k') | no next file » | no next file with comments »