tools/perf/measurements/task_execution_time.py - Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/task_execution_time.py

Issue 1124033004: [Telemetry] Kill PageTest.DidRunActions hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix task_execution_time. Thanks unittest! Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/task_execution_time.py

diff --git a/tools/perf/measurements/task_execution_time.py b/tools/perf/measurements/task_execution_time.py

index aa20f81c136d070cd15d2ac18ffd0ad57224e0d4..0ea328e1184b95941560fcd4d5b0447d31b9780c 100644

--- a/tools/perf/measurements/task_execution_time.py

+++ b/tools/perf/measurements/task_execution_time.py

@@ -53,14 +53,15 @@ class TaskExecutionTime(page_test.PageTest):

tab.browser.platform.tracing_controller.Start(

options, category_filter, self._TIME_OUT_IN_SECONDS)

- def DidRunActions(self, page, tab):

+ def ValidateAndMeasurePage(self, page, tab, results):

trace_data = tab.browser.platform.tracing_controller.Stop()

timeline_model = TimelineModel(trace_data)

self._renderer_process = timeline_model.GetRendererProcessFromTabId(tab.id)

self._browser_process = timeline_model.browser_process

+ self._AddResults(results)

- def ValidateAndMeasurePage(self, page, tab, results):

+ def _AddResults(self, results):

self._results = results

for thread in self._BROWSER_THREADS: