Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed)

Created:
5 years, 8 months ago by gburanov

Modified:
5 years, 8 months ago

Reviewers:

CC:
chromium-reviews, grt+watch_chromium.org, feature-media-reviews_chromium.org, caitkp+watch_chromium.org, eme-reviews_chromium.org, wfh+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

just some of possible refactorings possible after inventing branding_path_component fix errors in branding path component Merge branch 'master' of https://chromium.googlesource.com/chromium/src into simplify-if-branding-gyp Merge branch 'master' of https://chromium.googlesource.com/chromium/src into simplify-if-branding-gyp fixes according to review Merge branch 'master' of https://chromium.googlesource.com/chromium/src into simplify-if-branding-gyp Merge branch 'master' of https://chromium.googlesource.com/chromium/src into simplify-if-branding-gyp optimize branding - use branding_path_component variable for defining pranding specific paths BUG=

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -198 lines)			Patch
M	build/common.gypi	View	4 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+2 lines, -22 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View	1 chunk	+1 line, -11 lines	0 comments	Download
M	chrome/chrome_installer.gypi	View	4 chunks	+4 lines, -41 lines	0 comments	Download
M	chrome/installer/installer_tools.gyp	View	2 chunks	+1 line, -10 lines	0 comments	Download
M	chrome/installer/mini_installer.gyp	View	3 chunks	+1 line, -29 lines	0 comments	Download
M	chrome/installer/mini_installer_syzygy.gyp	View	2 chunks	+1 line, -10 lines	0 comments	Download
M	chrome/installer/upgrade_test.gyp	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	chrome_elf/chrome_elf.gyp	View	1 chunk	+1 line, -11 lines	0 comments	Download
M	cloud_print/cloud_print_resources.gyp	View	3 chunks	+1 line, -22 lines	0 comments	Download
M	media/media_cdm.gypi	View	1 chunk	+1 line, -11 lines	0 comments	Download
M	third_party/widevine/cdm/widevine_cdm.gyp	View	1 chunk	+1 line, -11 lines	0 comments	Download
M	win8/metro_driver/metro_driver.gyp	View	1 chunk	+1 line, -11 lines	0 comments	Download