Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: media/media_cdm.gypi

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cloud_print/cloud_print_resources.gyp ('k') | third_party/widevine/cdm/widevine_cdm.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'conditions': [ 7 'conditions': [
8 ['OS == "android"', { 8 ['OS == "android"', {
9 # Android doesn't use ffmpeg. 9 # Android doesn't use ffmpeg.
10 'use_ffmpeg%': 0, 10 'use_ffmpeg%': 0,
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 'cdm/ppapi/external_clear_key/clear_key_cdm.h', 94 'cdm/ppapi/external_clear_key/clear_key_cdm.h',
95 'cdm/ppapi/external_clear_key/clear_key_cdm_common.h', 95 'cdm/ppapi/external_clear_key/clear_key_cdm_common.h',
96 ], 96 ],
97 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 97 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
98 'msvs_disabled_warnings': [ 4267, ], 98 'msvs_disabled_warnings': [ 4267, ],
99 }, 99 },
100 { 100 {
101 # GN version: //media/cdm/ppapi:clearkeycdmadapter_resources 101 # GN version: //media/cdm/ppapi:clearkeycdmadapter_resources
102 'target_name': 'clearkeycdmadapter_resources', 102 'target_name': 'clearkeycdmadapter_resources',
103 'type': 'none', 103 'type': 'none',
104 'conditions': [
105 ['branding == "Chrome"', {
106 'variables': {
107 'branding_path': '../chrome/app/theme/google_chrome/BRANDING',
108 },
109 }, { # else branding!="Chrome"
110 'variables': {
111 'branding_path': '../chrome/app/theme/chromium/BRANDING',
112 },
113 }],
114 ],
115 'variables': { 104 'variables': {
116 'output_dir': '.', 105 'output_dir': '.',
106 'branding_path': '../chrome/app/theme/<(branding_path_component)/BRA NDING',
117 'template_input_path': '../chrome/app/chrome_version.rc.version', 107 'template_input_path': '../chrome/app/chrome_version.rc.version',
118 'extra_variable_files_arguments': 108 'extra_variable_files_arguments':
119 [ '-f', 'cdm/ppapi/external_clear_key/BRANDING' ], 109 [ '-f', 'cdm/ppapi/external_clear_key/BRANDING' ],
120 'extra_variable_files': [ 'cdm/ppapi/external_clear_key/BRANDING' ], 110 'extra_variable_files': [ 'cdm/ppapi/external_clear_key/BRANDING' ],
121 }, 111 },
122 'sources': [ 112 'sources': [
123 'clearkeycdmadapter.ver', 113 'clearkeycdmadapter.ver',
124 ], 114 ],
125 'includes': [ 115 'includes': [
126 '../chrome/version_resource_rules.gypi', 116 '../chrome/version_resource_rules.gypi',
(...skipping 23 matching lines...) Expand all
150 # Built by clearkeycdm. 140 # Built by clearkeycdm.
151 '<(PRODUCT_DIR)/libclearkeycdm.so', 141 '<(PRODUCT_DIR)/libclearkeycdm.so',
152 ], 142 ],
153 }], 143 }],
154 ], 144 ],
155 }, 145 },
156 ], 146 ],
157 }], 147 }],
158 ], 148 ],
159 } 149 }
OLDNEW
« no previous file with comments | « cloud_print/cloud_print_resources.gyp ('k') | third_party/widevine/cdm/widevine_cdm.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698