Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/installer/upgrade_test.gyp

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/mini_installer_syzygy.gyp ('k') | chrome_elf/chrome_elf.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'branding_dir': '../app/theme/<(branding_path_component)',
7 'version_py': '<(DEPTH)/build/util/version.py', 8 'version_py': '<(DEPTH)/build/util/version.py',
8 'version_path': '../../chrome/VERSION', 9 'version_path': '../../chrome/VERSION',
9 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE', 10 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE',
10 # 'branding_dir' is set in the 'conditions' section at the bottom. 11 # 'branding_dir' is set in the 'conditions' section at the bottom.
11 'msvs_use_common_release': 0, 12 'msvs_use_common_release': 0,
12 'msvs_use_common_linker_extras': 0, 13 'msvs_use_common_linker_extras': 0,
13 }, 14 },
14 'includes': [ 15 'includes': [
15 '../../build/win_precompile.gypi', 16 '../../build/win_precompile.gypi',
16 ], 17 ],
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 '../..', 81 '../..',
81 ], 82 ],
82 'sources': [ 83 'sources': [
83 'test/alternate_version_generator_main.cc', 84 'test/alternate_version_generator_main.cc',
84 ], 85 ],
85 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 86 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
86 'msvs_disabled_warnings': [ 4267, ], 87 'msvs_disabled_warnings': [ 4267, ],
87 }, 88 },
88 ], 89 ],
89 }], 90 }],
90 [ 'branding == "Chrome"', {
91 'variables': {
92 'branding_dir': '../app/theme/google_chrome',
93 },
94 }, { # else branding!="Chrome"
95 'variables': {
96 'branding_dir': '../app/theme/chromium',
97 },
98 }],
99 ], 91 ],
100 } 92 }
OLDNEW
« no previous file with comments | « chrome/installer/mini_installer_syzygy.gyp ('k') | chrome_elf/chrome_elf.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698