Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: chrome/installer/mini_installer.gyp

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/installer_tools.gyp ('k') | chrome/installer/mini_installer_syzygy.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'variables': { 2 'variables': {
3 'version_py': '<(DEPTH)/build/util/version.py', 3 'version_py': '<(DEPTH)/build/util/version.py',
4 'version_path': '../../chrome/VERSION', 4 'version_path': '../../chrome/VERSION',
5 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE', 5 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE',
6 # 'branding_dir' is set in the 'conditions' section at the bottom. 6 'branding_dir': '../app/theme/<(branding_path_component)',
7 'msvs_use_common_release': 0, 7 'msvs_use_common_release': 0,
8 'msvs_use_common_linker_extras': 0, 8 'msvs_use_common_linker_extras': 0,
9 'mini_installer_internal_deps%': 0, 9 'mini_installer_internal_deps%': 0,
10 'mini_installer_official_deps%': 0, 10 'mini_installer_official_deps%': 0,
11 }, 11 },
12 'includes': [ 12 'includes': [
13 '../../build/win_precompile.gypi', 13 '../../build/win_precompile.gypi',
14 ], 14 ],
15 'conditions': [ 15 'conditions': [
16 ['OS=="win"', { 16 ['OS=="win"', {
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 #'--distribution=$(CHROMIUM_BUILD)', 291 #'--distribution=$(CHROMIUM_BUILD)',
292 '--distribution=_google_chrome', 292 '--distribution=_google_chrome',
293 # Optional arguments to generate diff installer 293 # Optional arguments to generate diff installer
294 #'--last_chrome_installer=C:/Temp/base', 294 #'--last_chrome_installer=C:/Temp/base',
295 #'--setup_exe_format=DIFF', 295 #'--setup_exe_format=DIFF',
296 #'--diff_algorithm=COURGETTE', 296 #'--diff_algorithm=COURGETTE',
297 ], 297 ],
298 'message': 'Create installer archive', 298 'message': 'Create installer archive',
299 }, 299 },
300 ], 300 ],
301 # TODO(mark): <(branding_dir) should be defined by the
302 # global condition block at the bottom of the file, but
303 # this doesn't work due to the following issue:
304 #
305 # http://code.google.com/p/gyp/issues/detail?id=22
306 #
307 # Remove this block once the above issue is fixed.
308 'conditions': [
309 [ 'branding == "Chrome"', {
310 'variables': {
311 'branding_dir': '../app/theme/google_chrome',
312 },
313 }, { # else branding!="Chrome"
314 'variables': {
315 'branding_dir': '../app/theme/chromium',
316 },
317 }],
318 ],
319 }, 301 },
320 ], 302 ],
321 'conditions': [ 303 'conditions': [
322 ['test_isolation_mode != "noop"', { 304 ['test_isolation_mode != "noop"', {
323 'targets': [ 305 'targets': [
324 { 306 {
325 'target_name': 'mini_installer_tests_run', 307 'target_name': 'mini_installer_tests_run',
326 'type': 'none', 308 'type': 'none',
327 'dependencies': [ 309 'dependencies': [
328 'mini_installer', 310 'mini_installer',
329 ], 311 ],
330 'includes': [ 312 'includes': [
331 '../../build/isolate.gypi', 313 '../../build/isolate.gypi',
332 ], 314 ],
333 'sources': [ 315 'sources': [
334 'mini_installer_tests.isolate', 316 'mini_installer_tests.isolate',
335 ], 317 ],
336 }, 318 },
337 ], 319 ],
338 }], 320 }],
339 ], 321 ],
340 }], 322 }],
341 [ 'branding == "Chrome"', {
342 'variables': {
343 'branding_dir': '../app/theme/google_chrome',
344 },
345 }, { # else branding!="Chrome"
346 'variables': {
347 'branding_dir': '../app/theme/chromium',
348 },
349 }],
350 ],
351 } 323 }
OLDNEW
« no previous file with comments | « chrome/installer/installer_tools.gyp ('k') | chrome/installer/mini_installer_syzygy.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698