win8/metro_driver/metro_driver.gyp - Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win8/metro_driver/metro_driver.gyp

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win8/metro_driver/metro_driver.gyp

diff --git a/win8/metro_driver/metro_driver.gyp b/win8/metro_driver/metro_driver.gyp

index ce09c1d449cbe5418d8df80a6fe223ae9ab4bcbf..1a815e44d8d459bf0f8f5bf285478fef98c68ab7 100644

--- a/win8/metro_driver/metro_driver.gyp

+++ b/win8/metro_driver/metro_driver.gyp

@@ -31,19 +31,9 @@

{

'target_name': 'metro_driver_version_resources',

'type': 'none',

- 'conditions': [

- ['branding == "Chrome"', {

- 'variables': {

- 'branding_path': '../../chrome/app/theme/google_chrome/BRANDING',

- },

- }, { # else branding!="Chrome"

- 'variables': {

- 'branding_path': '../../chrome/app/theme/chromium/BRANDING',

- },

- }],

- ],

'variables': {

'output_dir': 'metro_driver',

+ 'branding_path': '../../chrome/app/theme/<(branding_path_component)/BRANDING',

'template_input_path': '../../chrome/app/chrome_version.rc.version',

'sources': [

« no previous file with comments | « third_party/widevine/cdm/widevine_cdm.gyp ('k') | no next file » | no next file with comments »