media/media_cdm.gypi - Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/media_cdm.gypi

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/media_cdm.gypi

diff --git a/media/media_cdm.gypi b/media/media_cdm.gypi

index 7d927324ac31de75805f8d3fc56c59e0947fa06c..1068aa1580ff9980a39a898d44a69e307e141acd 100644

--- a/media/media_cdm.gypi

+++ b/media/media_cdm.gypi

@@ -101,19 +101,9 @@

# GN version: //media/cdm/ppapi:clearkeycdmadapter_resources

'target_name': 'clearkeycdmadapter_resources',

'type': 'none',

- 'conditions': [

- ['branding == "Chrome"', {

- 'variables': {

- 'branding_path': '../chrome/app/theme/google_chrome/BRANDING',

- },

- }, { # else branding!="Chrome"

- 'variables': {

- 'branding_path': '../chrome/app/theme/chromium/BRANDING',

- },

- }],

- ],

'variables': {

'output_dir': '.',

+ 'branding_path': '../chrome/app/theme/<(branding_path_component)/BRANDING',

'template_input_path': '../chrome/app/chrome_version.rc.version',

'extra_variable_files_arguments':

[ '-f', 'cdm/ppapi/external_clear_key/BRANDING' ],

« no previous file with comments | « cloud_print/cloud_print_resources.gyp ('k') | third_party/widevine/cdm/widevine_cdm.gyp » ('j') | no next file with comments »