Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chrome/installer/upgrade_test.gyp

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mini_installer_syzygy.gyp ('k') | chrome_elf/chrome_elf.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/upgrade_test.gyp
diff --git a/chrome/installer/upgrade_test.gyp b/chrome/installer/upgrade_test.gyp
index 061604ed6ed5759937ce508d43966b5ae9c59247..bccc94dbfcc6e2bfa3fb2e739cd318b9d9c8e696 100644
--- a/chrome/installer/upgrade_test.gyp
+++ b/chrome/installer/upgrade_test.gyp
@@ -4,6 +4,7 @@
{
'variables': {
+ 'branding_dir': '../app/theme/<(branding_path_component)',
'version_py': '<(DEPTH)/build/util/version.py',
'version_path': '../../chrome/VERSION',
'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE',
@@ -87,14 +88,5 @@
},
],
}],
- [ 'branding == "Chrome"', {
- 'variables': {
- 'branding_dir': '../app/theme/google_chrome',
- },
- }, { # else branding!="Chrome"
- 'variables': {
- 'branding_dir': '../app/theme/chromium',
- },
- }],
],
}
« no previous file with comments | « chrome/installer/mini_installer_syzygy.gyp ('k') | chrome_elf/chrome_elf.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698