chrome_elf/chrome_elf.gyp - Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/chrome_elf.gyp

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_elf/chrome_elf.gyp

diff --git a/chrome_elf/chrome_elf.gyp b/chrome_elf/chrome_elf.gyp

index 0b612a87c6ec5e73c2d58b5915cf63822b6f9ec2..cbbb4b4b580717ff5fd51a327076d7fd1953b87d 100644

--- a/chrome_elf/chrome_elf.gyp

+++ b/chrome_elf/chrome_elf.gyp

@@ -15,19 +15,9 @@

{

'target_name': 'chrome_elf_resources',

'type': 'none',

- 'conditions': [

- ['branding == "Chrome"', {

- 'variables': {

- 'branding_path': '../chrome/app/theme/google_chrome/BRANDING',

- },

- }, { # else branding!="Chrome"

- 'variables': {

- 'branding_path': '../chrome/app/theme/chromium/BRANDING',

- },

- }],

- ],

'variables': {

'output_dir': 'chrome_elf',

+ 'branding_path': '../chrome/app/theme/<(branding_path_component)/BRANDING',

'template_input_path': '../chrome/app/chrome_version.rc.version',

'sources': [

« no previous file with comments | « chrome/installer/upgrade_test.gyp ('k') | cloud_print/cloud_print_resources.gyp » ('j') | no next file with comments »