Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Side by Side Diff: chrome_elf/chrome_elf.gyp

Issue 1105633003: just some of possible refactorings possible after inventing branding_path_component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/upgrade_test.gyp ('k') | cloud_print/cloud_print_resources.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 'chromium_code': 1, 6 'chromium_code': 1,
7 }, 7 },
8 'includes': [ 8 'includes': [
9 '../build/util/version.gypi', 9 '../build/util/version.gypi',
10 '../build/win_precompile.gypi', 10 '../build/win_precompile.gypi',
11 'blacklist.gypi', 11 'blacklist.gypi',
12 'dll_hash.gypi', 12 'dll_hash.gypi',
13 ], 13 ],
14 'targets': [ 14 'targets': [
15 { 15 {
16 'target_name': 'chrome_elf_resources', 16 'target_name': 'chrome_elf_resources',
17 'type': 'none', 17 'type': 'none',
18 'conditions': [
19 ['branding == "Chrome"', {
20 'variables': {
21 'branding_path': '../chrome/app/theme/google_chrome/BRANDING',
22 },
23 }, { # else branding!="Chrome"
24 'variables': {
25 'branding_path': '../chrome/app/theme/chromium/BRANDING',
26 },
27 }],
28 ],
29 'variables': { 18 'variables': {
30 'output_dir': 'chrome_elf', 19 'output_dir': 'chrome_elf',
20 'branding_path': '../chrome/app/theme/<(branding_path_component)/BRANDIN G',
31 'template_input_path': '../chrome/app/chrome_version.rc.version', 21 'template_input_path': '../chrome/app/chrome_version.rc.version',
32 }, 22 },
33 'sources': [ 23 'sources': [
34 'chrome_elf.ver', 24 'chrome_elf.ver',
35 ], 25 ],
36 'includes': [ 26 'includes': [
37 '../chrome/version_resource_rules.gypi', 27 '../chrome/version_resource_rules.gypi',
38 ], 28 ],
39 }, 29 },
40 { 30 {
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 # Set /SUBSYSTEM:WINDOWS. 196 # Set /SUBSYSTEM:WINDOWS.
207 'SubSystem': '2', 197 'SubSystem': '2',
208 }, 198 },
209 }, 199 },
210 }, 200 },
211 ], 201 ],
212 }], 202 }],
213 ], 203 ],
214 } 204 }
215 205
OLDNEW
« no previous file with comments | « chrome/installer/upgrade_test.gyp ('k') | cloud_print/cloud_print_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698