Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cleanup
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission. This is to allow Chromium to stop supporting grantWebNotificationPermission and switch to setPermission() for notifications permissions handling. This is part of a suite of four patches: Part 1: <this> Part 2: https://codereview.chromium.org/1099943003 Part 3: https://codereview.chromium.org/1100163002 Part 4: https://codereview.chromium.org/1056633003 BUG=475141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194285

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -69 lines) Patch
M LayoutTests/http/tests/notifications/click-dedicated-worker.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/click-document.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/click-shared-worker.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/click-window-focus-document.html View 3 chunks +4 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/close-dedicated-worker.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/close-dispatch-asynchronous.html View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/close-document.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/close-on-document-unload.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/close-shared-worker.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/notification-sandbox-permission.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/notifications/permission-document.html View 1 1 chunk +49 lines, -12 lines 0 comments Download
M LayoutTests/http/tests/notifications/request-permission-detached-context.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/request-permission-granted.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworker-notificationclick-openwindow-crash.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-click.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-close.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-data-invalid.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-direction.html View 3 chunks +3 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-redirect.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow-404.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-no-permission.html View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-get.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-get-close.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-get-filter.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-get-from-service-worker.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-click.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-get.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-get-filter.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-abort.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow-404.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-no-permission.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/update-dedicated-worker.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/update-document.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/update-shared-worker.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications.php View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/notificationclick-can-focus.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/notificationclick-can-openwindow.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/windowclient-focus.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
mlamouri (slow - plz ping)
5 years, 8 months ago (2015-04-22 18:10:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097383006/20001
5 years, 8 months ago (2015-04-22 18:10:50 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/60367)
5 years, 8 months ago (2015-04-22 22:23:57 UTC) #6
Mike West
LGTM % one of the test failures looks real.
5 years, 8 months ago (2015-04-23 08:50:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097383006/40001
5 years, 8 months ago (2015-04-23 10:40:29 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 11:51:55 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194285

Powered by Google App Engine
This is Rietveld 408576698