LayoutTests/http/tests/notifications/serviceworker-notificationclick-openwindow-crash.html - Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission.

Side by Side Diff: LayoutTests/http/tests/notifications/serviceworker-notificationclick-openwindow-crash.html

Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup

Patch Set: fix expectations Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html ('k') | LayoutTests/http/tests/notifications/serviceworkerregistration-document-click.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Notifications: Calling openWindow() in a Service Worker should not cr ash.</title>	4 <title>Notifications: Calling openWindow() in a Service Worker should not cr ash.</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="../serviceworker/resources/test-helpers.js"></script>	7 <script src="../serviceworker/resources/test-helpers.js"></script>

8 <script src="resources/test-helpers.js"></script>	8 <script src="resources/test-helpers.js"></script>

9 </head>	9 </head>

10 <body>	10 <body>

11 <script>	11 <script>

12 // Tests that calling openWindow() in a Service Worker in response to a	12 // Tests that calling openWindow() in a Service Worker in response to a

13 // notificationclick event does not cause the browser to crash.	13 // notificationclick event does not cause the browser to crash.

14	14

15 async_test(function(test) {	15 async_test(function(test) {

16 var scope = 'resources/scope/' + location.pathname,	16 var scope = 'resources/scope/' + location.pathname,

17 script = 'resources/instrumentation-service-worker.js',	17 script = 'resources/instrumentation-service-worker.js',

18 workerInfo = null;	18 workerInfo = null;

19	19

	20 testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

20 testRunner.grantWebNotificationPermission(location.origin, true);	21 testRunner.grantWebNotificationPermission(location.origin, true);

21 getActiveServiceWorkerWithMessagePort(test, script, scope).then(functi on(info) {	22 getActiveServiceWorkerWithMessagePort(test, script, scope).then(functi on(info) {

22 workerInfo = info;	23 workerInfo = info;

23	24

24 // (1) Display a persistent notification with an OPENWINDOW trigge r.	25 // (1) Display a persistent notification with an OPENWINDOW trigge r.

25 return workerInfo.registration.showNotification(scope, {	26 return workerInfo.registration.showNotification(scope, {

26 body: 'ACTION:OPENWINDOW'	27 body: 'ACTION:OPENWINDOW'

27 });	28 });

28 }).then(function() {	29 }).then(function() {

29 // (2) Simulate a click on the notification, invokes the Service W orker event.	30 // (2) Simulate a click on the notification, invokes the Service W orker event.

(...skipping 10 matching lines...) Expand all Loading...
40 assert_equals(event.data.command, 'click');	41 assert_equals(event.data.command, 'click');

41 assert_equals(event.data.notification.title, scope);	42 assert_equals(event.data.notification.title, scope);

42	43

43 test.done();	44 test.done();

44 });	45 });

45 }).catch(unreached_rejection(test));	46 }).catch(unreached_rejection(test));

46	47

47 }, 'Opening a window in a Service Worker should not trigger a DCHECK.');	48 }, 'Opening a window in a Service Worker should not trigger a DCHECK.');

48 </script>	49 </script>

49 </body>	50 </body>

50 </html>	51 </html>

OLD	NEW