LayoutTests/http/tests/notifications/close-shared-worker.html - Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/close-shared-worker.html

Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup

Patch Set: fix expectations Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/close-on-document-unload.html ('k') | LayoutTests/http/tests/notifications/notification-sandbox-permission.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/close-shared-worker.html

diff --git a/LayoutTests/http/tests/notifications/close-shared-worker.html b/LayoutTests/http/tests/notifications/close-shared-worker.html

index 7e0d774068a656cf0af05f0c7d1964e351429aaa..7243e1b6eeafdfc7448c497d43c5898924eb7da5 100644

--- a/LayoutTests/http/tests/notifications/close-shared-worker.html

+++ b/LayoutTests/http/tests/notifications/close-shared-worker.html

@@ -11,10 +11,12 @@

// Tests that Shared Worker-bound notifications will fire the onclose

// event when they have their close() method called. When the test is being

// ran manually, grant Notification permission first.

- if (window.testRunner)

+ if (window.testRunner) {

+ testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

testRunner.grantWebNotificationPermission(location.origin, true);

+ }

sharedWorkerTest("resources/close-event-test.js");

</script>

</body>

-</html>

+</html>