Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup
Patch Set: fix expectations Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html
diff --git a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html
index cc6396b00ec84a39fa566dca9da21c73ca0da92f..131f0b45379ec2eebdd409b4d2be72fd116cdd64 100644
--- a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html
+++ b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html
@@ -14,8 +14,10 @@
var scope = 'resources/scope/service-worker-show-notification-not-activated',
workerUrl = 'resources/empty-worker.js';
- if (window.testRunner)
+ if (window.testRunner) {
+ testRunner.setPermission('notifications', 'denied', location.origin, location.origin);
testRunner.grantWebNotificationPermission(location.origin, false);
+ }
service_worker_unregister_and_register(test, workerUrl, scope).then(function(registration) {
assert_inherits(registration, 'showNotification', 'showNotification() must be exposed.');
@@ -36,4 +38,4 @@
</script>
</body>
-</html>
+</html>

Powered by Google App Engine
This is Rietveld 408576698