Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1100163002: Notifications: stop using notifications specific permission methods in LayoutTests. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@notifications_testrunner_setpermission
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Notifications: stop using notifications specific permission methods in LayoutTests. This is part of a suite of four patches: Part 1: https://codereview.chromium.org/1097383006 Part 2: https://codereview.chromium.org/1099943003 Part 3: <this> Part 4: https://codereview.chromium.org/1056633003 BUG=475141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194324

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -102 lines) Patch
M LayoutTests/http/tests/notifications/click-dedicated-worker.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/click-document.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/click-shared-worker.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/click-window-focus-document.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/close-dedicated-worker.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/close-dispatch-asynchronous.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/close-document.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/close-on-document-unload.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/close-shared-worker.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/notification-properties.html View 2 chunks +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/notifications/notification-sandbox-permission.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/notification-sandbox-permission-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/permission-document.html View 1 3 chunks +0 lines, -11 lines 0 comments Download
M LayoutTests/http/tests/notifications/request-permission-denied.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/notifications/request-permission-detached-context.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/request-permission-granted.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworker-notificationclick-openwindow-crash.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-click.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-close.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-data-invalid.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-direction.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-redirect.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow-404.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-no-permission.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-get.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-get-close.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-get-filter.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-get-from-service-worker.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-click.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-get.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-get-filter.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-abort.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow-404.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-no-permission.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/update-dedicated-worker.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/update-document.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/notifications/update-shared-worker.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications.php View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/notificationclick-can-focus.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/notificationclick-can-openwindow.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/windowclient-focus.html View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mlamouri (slow - plz ping)
5 years, 8 months ago (2015-04-22 18:11:34 UTC) #2
Mike West
LGTM
5 years, 8 months ago (2015-04-23 08:51:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100163002/20001
5 years, 8 months ago (2015-04-23 19:24:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100163002/40001
5 years, 8 months ago (2015-04-23 19:32:20 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 20:43:12 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194324

Powered by Google App Engine
This is Rietveld 408576698