Issue 1099943003: Notifications: use LayoutTestPermissionManager to handle permissions.

Issue 1099943003: Notifications: use LayoutTestPermissionManager to handle permissions. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)

Modified:
5 years, 8 months ago

Reviewers:
Mike West

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_midiclientmock

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Notifications: use LayoutTestPermissionManager to handle permissions. This is part of a suite of four patches: Part 1: https://codereview.chromium.org/1097383006 Part 2: <this> Part 3: https://codereview.chromium.org/1100163002 Part 4: https://codereview.chromium.org/1056633003 BUG=475141 Committed: https://crrev.com/723324dcf07b0dd6c61c51e1fff4a160f7e65df8 Cr-Commit-Position: refs/heads/master@{#326533}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -176 lines)			Patch
M	content/shell/browser/layout_test/layout_test_message_filter.cc	View	2 chunks	+0 lines, -22 lines	0 comments	Download
M	content/shell/browser/layout_test/layout_test_notification_manager.h	View	4 chunks	+10 lines, -31 lines	0 comments	Download
M	content/shell/browser/layout_test/layout_test_notification_manager.cc	View	5 chunks	+29 lines, -46 lines	0 comments	Download
M	content/shell/browser/layout_test/layout_test_permission_manager.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	content/shell/browser/layout_test/layout_test_permission_manager.cc	View	8 chunks	+21 lines, -31 lines	0 comments	Download
M	content/shell/common/layout_test/layout_test_messages.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/shell/renderer/layout_test/webkit_test_runner.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/shell/renderer/layout_test/webkit_test_runner.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	content/shell/renderer/test_runner/test_runner.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/shell/renderer/test_runner/test_runner.cc	View	2 chunks	+0 lines, -19 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_test_delegate.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 7 (2 generated)

Mike West

LGTM. I don't like the lock, but I don't see another way to do it ...

5 years, 8 months ago (2015-04-23 08:51:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099943003/20001

5 years, 8 months ago (2015-04-23 15:38:23 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-23 16:12:45 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/723324dcf07b0dd6c61c51e1fff4a160f7e65df8
Cr-Commit-Position: refs/heads/master@{#326533}