LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html - Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html

Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup

Patch Set: fix expectations Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-get-filter.html ('k') | LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-abort.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html

diff --git a/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html b/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html

index 53bfbb6cfae0ecbb63931fe8ae6c16ff89b1d512..700c4306b972c406b34515c459f9f51b28cb6039 100644

--- a/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html

+++ b/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html

@@ -16,6 +16,7 @@

var scope = 'resources/scope/' + location.pathname,

script = 'resources/instrumentation-service-worker.js';

+ testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

testRunner.grantWebNotificationPermission(location.origin, true);

getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(info) {

// (1) Display a Web Notification through the Service Worker with

@@ -46,4 +47,4 @@

}, 'Displaying a notification with an image that 404s still resolves the promise.');

</script>

</body>

-</html>

+</html>