LayoutTests/http/tests/serviceworker/chromium/notificationclick-can-openwindow.html - Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/chromium/notificationclick-can-openwindow.html

Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup

Patch Set: fix expectations Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/chromium/notificationclick-can-focus.html ('k') | LayoutTests/http/tests/serviceworker/chromium/windowclient-focus.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Service Worker: notificationclick can open new WindowClient</title>	2 <title>Service Worker: notificationclick can open new WindowClient</title>

3 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

4 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

5 <script src="../resources/test-helpers.js"></script>	5 <script src="../resources/test-helpers.js"></script>

6 <script>	6 <script>

7 if (window.testRunner)	7 if (window.testRunner) {

	8 testRunner.setPermission('notifications', 'granted', location.origin, locati on.origin);

8 testRunner.grantWebNotificationPermission(location.origin, true);	9 testRunner.grantWebNotificationPermission(location.origin, true);

	10 }

9	11

10 var t = async_test('notificationclick can open new WindowClient');	12 var t = async_test('notificationclick can open new WindowClient');

11 t.step(function() {	13 t.step(function() {

12 var scope = 'resources/blank.html'	14 var scope = 'resources/blank.html'

13 service_worker_unregister_and_register(	15 service_worker_unregister_and_register(

14 t, 'resources/notificationclick-can-openwindow.js', scope)	16 t, 'resources/notificationclick-can-openwindow.js', scope)

15 .then(function(registration) {	17 .then(function(registration) {

16 return wait_for_state(t, registration.installing, 'activated');	18 return wait_for_state(t, registration.installing, 'activated');

17 })	19 })

18 .then(function() { return with_iframe(scope); })	20 .then(function() { return with_iframe(scope); })

(...skipping 27 matching lines...) Expand all Loading...
46 if (message === 'quit') {	48 if (message === 'quit') {

47 assert_array_equals(result, expected,	49 assert_array_equals(result, expected,

48 'Worker should post back expected messages.');	50 'Worker should post back expected messages.');

49 service_worker_unregister_and_done(t, scope);	51 service_worker_unregister_and_done(t, scope);

50 } else {	52 } else {

51 result.push(message);	53 result.push(message);

52 }	54 }

53 }	55 }

54 });	56 });

55 </script>	57 </script>

OLD	NEW