LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html - Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup

Patch Set: fix expectations Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications.php ('k') | LayoutTests/http/tests/serviceworker/chromium/notificationclick-can-focus.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

diff --git a/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html b/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

index 4b4e6a3f939263f50a3782c79cdafdae2ab171f7..1d07ec1904bed0f2f64daa672a2e67a7f31debaa 100644

--- a/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

+++ b/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

@@ -7,8 +7,10 @@

// This test is using testRunner to grant itself the notification permission and

// to simulate a click on a notification. A couple of changes would allow it to

// be run as a manual test by other browser vendors.

-if (window.testRunner)

+if (window.testRunner) {

+ testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

testRunner.grantWebNotificationPermission(location.origin, true);

var t = async_test('clients.openWindow() behaved as expected');

t.step(function() {