Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1056633003: Remove TestRunner notifications permissions calls. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@layout_tests_notifications_permissions
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TestRunner notifications permissions calls. This is part of a suite of four patches: Part 1: https://codereview.chromium.org/1097383006 Part 2: https://codereview.chromium.org/1099943003 Part 3: https://codereview.chromium.org/1100163002 Part 4: <this> BUG=475141 Committed: https://crrev.com/36b5175060ed76723abb89a0aa7f1563c43ff4c5 Cr-Commit-Position: refs/heads/master@{#326792}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/shell/renderer/test_runner/test_runner.cc View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mlamouri (slow - plz ping)
5 years, 8 months ago (2015-04-22 18:11:44 UTC) #2
Mike West
LGTM
5 years, 8 months ago (2015-04-23 08:52:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056633003/20001
5 years, 8 months ago (2015-04-24 14:17:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 14:42:54 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 14:43:48 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36b5175060ed76723abb89a0aa7f1563c43ff4c5
Cr-Commit-Position: refs/heads/master@{#326792}

Powered by Google App Engine
This is Rietveld 408576698