Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1073863003: DevTools: remove Canvas profiler from DevTools source base. See details in the bug. (Closed)

Created:
5 years, 8 months ago by pfeldman
Modified:
5 years, 8 months ago
Reviewers:
paulirish, dgozman
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, arv+blink, blink-reviews, caseq+blink_chromium.org, Inactive, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vivekg_samsung, vivekg, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: remove Canvas profiler from DevTools source base. See details in the bug. BUG=475808 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193602

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : tests gone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10504 lines) Patch
M LayoutTests/FlakyTests View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/SlowTests View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas-profiler-test.js View 1 2 1 chunk +0 lines, -189 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas-get-resource-state.html View 1 2 1 chunk +0 lines, -99 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas-get-resource-state-expected.txt View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases-expected.txt View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas-replay-log-grid.html View 1 2 1 chunk +0 lines, -207 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas-stack-trace.html View 1 2 1 chunk +0 lines, -65 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas-stack-trace-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes.html View 1 2 1 chunk +0 lines, -187 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas2d-gradient-capturing.html View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas2d-gradient-capturing-expected.txt View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html View 1 2 1 chunk +0 lines, -311 lines 0 comments Download
D LayoutTests/inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics-expected.txt View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/inspector/profiler/webgl/webgl-get-resource-state.html View 1 2 1 chunk +0 lines, -198 lines 0 comments Download
D LayoutTests/inspector/profiler/webgl/webgl-get-resource-state-buffer-data.html View 1 2 1 chunk +0 lines, -152 lines 0 comments Download
D LayoutTests/inspector/profiler/webgl/webgl-get-resource-state-buffer-data-expected.txt View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/inspector/profiler/webgl/webgl-get-resource-state-expected.txt View 1 2 1 chunk +0 lines, -374 lines 0 comments Download
D LayoutTests/inspector/profiler/webgl/webgl-profiler-api-changes.html View 1 2 1 chunk +0 lines, -223 lines 0 comments Download
D LayoutTests/inspector/profiler/webgl/webgl-profiler-api-changes-expected.txt View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/inspector/profiler/webgl/webgl-profiler-enum-descriptions.html View 1 2 1 chunk +0 lines, -103 lines 0 comments Download
D LayoutTests/inspector/profiler/webgl/webgl-profiler-enum-descriptions-expected.txt View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error.html View 1 2 1 chunk +0 lines, -189 lines 0 comments Download
D LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error-expected.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/WrapCanvasContext.cpp View 1 2 3 chunks +0 lines, -13 lines 0 comments Download
M Source/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/core_generated.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScript.h View 2 chunks +0 lines, -2 lines 0 comments Download
D Source/core/inspector/InjectedScriptCanvasModule.h View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/core/inspector/InjectedScriptCanvasModule.cpp View 1 chunk +0 lines, -218 lines 0 comments Download
D Source/core/inspector/InjectedScriptCanvasModuleSource.js View 1 chunk +0 lines, -4587 lines 0 comments Download
D Source/core/inspector/InjectedScriptModule.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/core/inspector/InjectedScriptModule.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/core/inspector/InspectorCanvasAgent.h View 1 chunk +0 lines, -107 lines 0 comments Download
D Source/core/inspector/InspectorCanvasAgent.cpp View 1 chunk +0 lines, -354 lines 0 comments Download
D Source/core/inspector/InspectorCanvasInstrumentation.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorInstrumentation.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 2 2 chunks +2 lines, -14 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentationCustomInl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/PRESUBMIT.py View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/devtools/front_end/common/Settings.js View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D Source/devtools/front_end/profiler/CanvasProfileView.js View 1 chunk +0 lines, -1331 lines 0 comments Download
D Source/devtools/front_end/profiler/CanvasReplayStateView.js View 1 chunk +0 lines, -530 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfileTypeRegistry.js View 1 chunk +0 lines, -5 lines 0 comments Download
D Source/devtools/front_end/profiler/canvasProfiler.css View 1 chunk +0 lines, -175 lines 0 comments Download
M Source/devtools/front_end/profiler/module.json View 1 chunk +0 lines, -3 lines 0 comments Download
D Source/devtools/scripts/check_injected_webgl_calls_info.py View 1 chunk +0 lines, -155 lines 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 5 chunks +3 lines, -19 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M public/blink_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
pfeldman
5 years, 8 months ago (2015-04-12 17:18:30 UTC) #3
dgozman
lgtm Will you cleanup more stuff in follow-ups?
5 years, 8 months ago (2015-04-12 19:02:31 UTC) #4
paulirish
Lgtm on my side. To unsubscribe from this group and stop receiving emails from it, ...
5 years, 8 months ago (2015-04-12 19:18:43 UTC) #5
paulirish
lgtm
5 years, 8 months ago (2015-04-12 19:19:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073863003/60001
5 years, 8 months ago (2015-04-12 19:46:26 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-12 20:13:14 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193602

Powered by Google App Engine
This is Rietveld 408576698