|
|
Make more use of generated code in analysis server.
The following generated classes are now used:
- CompletionRelevance
- CompletionSuggestion
- CompletionSuggestionKind
- ErrorFixes
- HighlightRegion
- HighlightRegionType
- HoverInformation
- LinkedEditGroup
- LinkedEditSuggestion
- LinkedEditSuggestionKind
- SourceChange
Generated code is used to produce these notifications:
- analysis.errors
- analysis.highlights
- analysis.navigation
- search.results
- server.error
- server.status
Generated code is used to produce the response to these requests:
- analysis.getErrors
- analysis.getHover
- edit.getAssists
- edit.getFixes
- server.getVersion
Generated code is used to handle these notifications in unit testing:
- analysis.highlights
- analysis.navigation
In addition, these methods have been removed, since they are no longer
needed:
- Notification.getParameter
- Result.setEmptyResult
- Result.setResult
R=brianwilkerson@google.com
Committed: https://code.google.com/p/dart/source/detail?r=39511
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+892 lines, -1318 lines) |
Patch |
 |
M |
pkg/analysis_server/lib/src/analysis_server.dart
|
View
|
|
3 chunks |
+9 lines, -13 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/computer/computer_highlights.dart
|
View
|
|
21 chunks |
+105 lines, -241 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/computer/computer_hover.dart
|
View
|
|
4 chunks |
+4 lines, -69 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/computer/computer_navigation.dart
|
View
|
|
3 chunks |
+4 lines, -9 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/computer/error.dart
|
View
|
|
1 chunk |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/domain_analysis.dart
|
View
|
|
3 chunks |
+11 lines, -13 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/domain_completion.dart
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/domain_server.dart
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/edit/edit_domain.dart
|
View
|
|
5 chunks |
+10 lines, -17 lines |
0 comments
|
Download
|
 |
D |
pkg/analysis_server/lib/src/edit/fix.dart
|
View
|
|
1 chunk |
+0 lines, -35 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/generated_protocol.dart
|
View
|
|
23 chunks |
+133 lines, -4 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/operation/operation_analysis.dart
|
View
|
|
2 chunks |
+12 lines, -25 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/protocol.dart
|
View
|
|
5 chunks |
+21 lines, -38 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/protocol2.dart
|
View
|
|
4 chunks |
+79 lines, -0 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/search/search_domain.dart
|
View
|
|
2 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/completion/completion_manager.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
pkg/analysis_server/lib/src/services/completion/completion_suggestion.dart
|
View
|
|
1 chunk |
+0 lines, -237 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/completion/keyword_computer.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/completion/local_computer.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/correction/assist.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/correction/assist_internal.dart
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
D |
pkg/analysis_server/lib/src/services/correction/change.dart
|
View
|
|
1 chunk |
+0 lines, -174 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/correction/fix.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/correction/fix_internal.dart
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/correction/source_buffer.dart
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/generated/completion.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/refactoring/refactoring.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/refactoring/rename.dart
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/refactoring/rename_import.dart
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/refactoring/rename_library.dart
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/refactoring/rename_local.dart
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/analysis_notification_highlights_test.dart
|
View
|
|
55 chunks |
+170 lines, -176 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/analysis_server_test.dart
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/domain_analysis_test.dart
|
View
|
|
6 chunks |
+12 lines, -12 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/domain_completion_test.dart
|
View
|
|
2 chunks |
+7 lines, -12 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/edit/assists_test.dart
|
View
|
|
4 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/protocol_test.dart
|
View
|
|
4 chunks |
+7 lines, -26 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/services/completion/completion_computer_test.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/services/completion/completion_test_util.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/services/completion/imported_type_computer_test.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/services/completion/keyword_computer_test.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/services/correction/assist_test.dart
|
View
|
|
4 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/services/correction/change_test.dart
|
View
|
|
6 chunks |
+23 lines, -25 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/services/correction/fix_test.dart
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/services/refactoring/abstract_rename.dart
|
View
|
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/services/refactoring/extract_local_test.dart
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/socket_server_test.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/tool/spec/codegen_dart_protocol.dart
|
View
|
|
23 chunks |
+192 lines, -75 lines |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|