Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

Issue 497393002: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library services.src.refactoring.rename_constructor; 5 library services.src.refactoring.rename_constructor;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/src/protocol2.dart' show Location, SourceEdit; 9 import 'package:analysis_server/src/protocol2.dart' show Location,
10 import 'package:analysis_server/src/services/correction/change.dart'; 10 SourceChange, SourceEdit;
11 import 'package:analysis_server/src/services/correction/status.dart'; 11 import 'package:analysis_server/src/services/correction/status.dart';
12 import 'package:analysis_server/src/services/refactoring/refactoring.dart'; 12 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
13 import 'package:analysis_server/src/services/search/hierarchy.dart'; 13 import 'package:analysis_server/src/services/search/hierarchy.dart';
14 import 'package:analysis_server/src/services/search/search_engine.dart'; 14 import 'package:analysis_server/src/services/search/search_engine.dart';
15 import 'package:analysis_server/src/services/correction/util.dart'; 15 import 'package:analysis_server/src/services/correction/util.dart';
16 import 'package:analysis_server/src/services/refactoring/naming_conventions.dart '; 16 import 'package:analysis_server/src/services/refactoring/naming_conventions.dart ';
17 import 'package:analysis_server/src/services/refactoring/rename.dart'; 17 import 'package:analysis_server/src/services/refactoring/rename.dart';
18 import 'package:analyzer/src/generated/element.dart'; 18 import 'package:analyzer/src/generated/element.dart';
19 import 'package:analyzer/src/generated/java_core.dart'; 19 import 'package:analyzer/src/generated/java_core.dart';
20 20
(...skipping 22 matching lines...) Expand all
43 } 43 }
44 44
45 @override 45 @override
46 RefactoringStatus checkNewName() { 46 RefactoringStatus checkNewName() {
47 RefactoringStatus result = super.checkNewName(); 47 RefactoringStatus result = super.checkNewName();
48 result.addStatus(validateConstructorName(newName)); 48 result.addStatus(validateConstructorName(newName));
49 return result; 49 return result;
50 } 50 }
51 51
52 @override 52 @override
53 Future<Change> createChange() { 53 Future<SourceChange> createChange() {
54 Change change = new Change(refactoringName); 54 SourceChange change = new SourceChange(refactoringName);
55 String replacement = newName.isEmpty ? '' : '.${newName}'; 55 String replacement = newName.isEmpty ? '' : '.${newName}';
56 // update references 56 // update references
57 return searchEngine.searchReferences(element).then((refMatches) { 57 return searchEngine.searchReferences(element).then((refMatches) {
58 List<SourceReference> references = getSourceReferences(refMatches); 58 List<SourceReference> references = getSourceReferences(refMatches);
59 if (!element.isSynthetic) { 59 if (!element.isSynthetic) {
60 for (SourceReference reference in references) { 60 for (SourceReference reference in references) {
61 SourceEdit edit = createReferenceEdit(reference, replacement); 61 SourceEdit edit = createReferenceEdit(reference, replacement);
62 change.addEdit(reference.file, edit); 62 change.addEdit(reference.file, edit);
63 } 63 }
64 } 64 }
(...skipping 10 matching lines...) Expand all
75 "Class '{0}' already declares {1} with name '{2}'.", 75 "Class '{0}' already declares {1} with name '{2}'.",
76 parentClass.displayName, 76 parentClass.displayName,
77 getElementKindName(newNameMember), 77 getElementKindName(newNameMember),
78 newName); 78 newName);
79 result.addError( 79 result.addError(
80 message, 80 message,
81 new Location.fromElement(newNameMember)); 81 new Location.fromElement(newNameMember));
82 } 82 }
83 } 83 }
84 } 84 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698