Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Side by Side Diff: pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

Issue 497393002: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library services.src.refactoring.rename_unit_member; 5 library services.src.refactoring.rename_unit_member;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/src/protocol2.dart' show Location; 9 import 'package:analysis_server/src/protocol2.dart' show Location, SourceChange;
10 import 'package:analysis_server/src/services/correction/change.dart';
11 import 'package:analysis_server/src/services/correction/status.dart'; 10 import 'package:analysis_server/src/services/correction/status.dart';
12 import 'package:analysis_server/src/services/correction/util.dart'; 11 import 'package:analysis_server/src/services/correction/util.dart';
13 import 'package:analysis_server/src/services/refactoring/naming_conventions.dart '; 12 import 'package:analysis_server/src/services/refactoring/naming_conventions.dart ';
14 import 'package:analysis_server/src/services/refactoring/refactoring.dart'; 13 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
15 import 'package:analysis_server/src/services/refactoring/rename.dart'; 14 import 'package:analysis_server/src/services/refactoring/rename.dart';
16 import 'package:analysis_server/src/services/search/element_visitors.dart'; 15 import 'package:analysis_server/src/services/search/element_visitors.dart';
17 import 'package:analysis_server/src/services/search/search_engine.dart'; 16 import 'package:analysis_server/src/services/search/search_engine.dart';
18 import 'package:analyzer/src/generated/element.dart'; 17 import 'package:analyzer/src/generated/element.dart';
19 import 'package:analyzer/src/generated/java_core.dart'; 18 import 'package:analyzer/src/generated/java_core.dart';
20 19
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 if (element is FunctionTypeAliasElement) { 66 if (element is FunctionTypeAliasElement) {
68 result.addStatus(validateFunctionTypeAliasName(newName)); 67 result.addStatus(validateFunctionTypeAliasName(newName));
69 } 68 }
70 if (element is ClassElement) { 69 if (element is ClassElement) {
71 result.addStatus(validateClassName(newName)); 70 result.addStatus(validateClassName(newName));
72 } 71 }
73 return result; 72 return result;
74 } 73 }
75 74
76 @override 75 @override
77 Future<Change> createChange() { 76 Future<SourceChange> createChange() {
78 Change change = new Change(refactoringName); 77 SourceChange change = new SourceChange(refactoringName);
79 // prepare elements 78 // prepare elements
80 List<Element> elements = []; 79 List<Element> elements = [];
81 if (element is PropertyInducingElement && element.isSynthetic) { 80 if (element is PropertyInducingElement && element.isSynthetic) {
82 PropertyInducingElement property = element as PropertyInducingElement; 81 PropertyInducingElement property = element as PropertyInducingElement;
83 PropertyAccessorElement getter = property.getter; 82 PropertyAccessorElement getter = property.getter;
84 PropertyAccessorElement setter = property.setter; 83 PropertyAccessorElement setter = property.setter;
85 if (getter != null) { 84 if (getter != null) {
86 elements.add(getter); 85 elements.add(getter);
87 } 86 }
88 if (setter != null) { 87 if (setter != null) {
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 getElementKindName(element), 234 getElementKindName(element),
236 getElementKindName(member), 235 getElementKindName(member),
237 getElementQualifiedName(member)); 236 getElementQualifiedName(member));
238 result.addError(message, new Location.fromMatch(memberReference)); 237 result.addError(message, new Location.fromMatch(memberReference));
239 } 238 }
240 }); 239 });
241 }); 240 });
242 }); 241 });
243 } 242 }
244 } 243 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698