Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

Issue 497393002: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library services.completion.suggestion.builder; 5 library services.completion.suggestion.builder;
6 6
7 import 'package:analysis_server/src/services/completion/completion_suggestion.da rt'; 7 import 'package:analysis_server/src/protocol2.dart' show
8 CompletionRelevance, CompletionSuggestion, CompletionSuggestionKind;
8 import 'package:analysis_server/src/services/completion/dart_completion_manager. dart'; 9 import 'package:analysis_server/src/services/completion/dart_completion_manager. dart';
9 import 'package:analyzer/src/generated/element.dart'; 10 import 'package:analyzer/src/generated/element.dart';
10 11
11 /** 12 /**
12 * This class visits elements in a class and provides suggestions based upon 13 * This class visits elements in a class and provides suggestions based upon
13 * the visible members in that class. Clients should call 14 * the visible members in that class. Clients should call
14 * [ClassElementSuggestionBuilder.suggestionsFor]. 15 * [ClassElementSuggestionBuilder.suggestionsFor].
15 */ 16 */
16 class ClassElementSuggestionBuilder extends GeneralizingElementVisitor { 17 class ClassElementSuggestionBuilder extends GeneralizingElementVisitor {
17 final DartCompletionRequest request; 18 final DartCompletionRequest request;
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 visitTopLevelVariableElement(TopLevelVariableElement element) { 127 visitTopLevelVariableElement(TopLevelVariableElement element) {
127 _addSuggestion(element); 128 _addSuggestion(element);
128 } 129 }
129 130
130 void _addSuggestion(Element element) { 131 void _addSuggestion(Element element) {
131 if (element != null) { 132 if (element != null) {
132 String completion = element.name; 133 String completion = element.name;
133 if (completion != null && completion.length > 0) { 134 if (completion != null && completion.length > 0) {
134 request.suggestions.add( 135 request.suggestions.add(
135 new CompletionSuggestion( 136 new CompletionSuggestion(
136 CompletionSuggestionKind.fromElementKind(element.kind), 137 new CompletionSuggestionKind.fromElementKind(element.kind),
137 CompletionRelevance.DEFAULT, 138 CompletionRelevance.DEFAULT,
138 completion, 139 completion,
139 completion.length, 140 completion.length,
140 0, 141 0,
141 element.isDeprecated, 142 element.isDeprecated,
142 false)); 143 false));
143 } 144 }
144 } 145 }
145 } 146 }
146 147
147 /** 148 /**
148 * Add suggestions for the visible members in the given library 149 * Add suggestions for the visible members in the given library
149 */ 150 */
150 static void suggestionsFor(DartCompletionRequest request, 151 static void suggestionsFor(DartCompletionRequest request,
151 LibraryElement library) { 152 LibraryElement library) {
152 if (library != null) { 153 if (library != null) {
153 library.visitChildren(new LibraryElementSuggestionBuilder(request)); 154 library.visitChildren(new LibraryElementSuggestionBuilder(request));
154 } 155 }
155 } 156 }
156 } 157 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698