pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart - Issue 497393002: Make more use of generated code in analysis server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart

Issue 497393002: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart ('k') | pkg/analysis_server/lib/src/services/completion/keyword_computer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart b/pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart

index 7797a8b2dd87faa79a925dd871f28ecd92773a69..983751b05859592c793d98f5323552e2ceacc345 100644

--- a/pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart

+++ b/pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart

@@ -6,7 +6,8 @@ library services.completion.computer.dart.toplevel;

import 'dart:async';

-import 'package:analysis_server/src/services/completion/completion_suggestion.dart';

+import 'package:analysis_server/src/protocol2.dart' show

+ CompletionRelevance, CompletionSuggestion, CompletionSuggestionKind;

import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';

import 'package:analysis_server/src/services/completion/suggestion_builder.dart';

import 'package:analysis_server/src/services/search/search_engine.dart';

@@ -128,7 +129,7 @@ class _ImportedTypeVisitor extends GeneralizingAstVisitor<Future<bool>> {

(hide == null || !hide.contains(completion))) {

request.suggestions.add(

new CompletionSuggestion(

- CompletionSuggestionKind.fromElementKind(element.kind),

+ new CompletionSuggestionKind.fromElementKind(element.kind),

visibleLibs.contains(lib) || lib.isDartCore ?

CompletionRelevance.DEFAULT :

CompletionRelevance.LOW,