Make more use of generated code in analysis server.

pkg/analysis_server/test/protocol_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.protocol;
 
 import 'dart:convert';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/json.dart';
@@ skipping 41 matching lines @@
   }
 }
 
 
 @ReflectiveTestCase()
 class NotificationTest {
   void test_fromJson() {
     Notification original = new Notification('foo');
     Notification notification = new Notification.fromJson(original.toJson());
     expect(notification.event, equals('foo'));
-    expect(notification.params.length, equals(0));
-    expect(notification.getParameter('x'), isNull);
+    expect(notification.params, isNull);
   }
 
   void test_fromJson_withParams() {
     Notification original = new Notification('foo');
     original.setParameter('x', 'y');
     Notification notification = new Notification.fromJson(original.toJson());
     expect(notification.event, equals('foo'));
-    expect(notification.params.length, equals(1));
-    expect(notification.getParameter('x'), equals('y'));
+    expect(notification.params, equals({'x': 'y'}));
   }
 
-  void test_getParameter_defined() {
+  void test_toJson_withParams() {
     Notification notification = new Notification('foo');
     notification.setParameter('x', 'y');
     expect(notification.event, equals('foo'));
-    expect(notification.params.length, equals(1));
-    expect(notification.getParameter('x'), equals('y'));
+    expect(notification.params, equals({'x': 'y'}));
     expect(notification.toJson(), equals({
       'event': 'foo',
       'params': {
         'x': 'y'
       }
     }));
   }
 
-  void test_getParameter_undefined() {
+  void test_toJson_noParams() {
     Notification notification = new Notification('foo');
     expect(notification.event, equals('foo'));
-    expect(notification.params.length, equals(0));
-    expect(notification.getParameter('x'), isNull);
+    expect(notification.params, isNull);
     expect(notification.toJson(), equals({
       'event': 'foo'
     }));
   }
 
   void test_setParameter_HasToJson() {
     Notification notification = new Notification('foo');
     notification.setParameter('my', new _MyHasToJsonObject(42));
     expect(notification.toJson(), equals({
       'event': 'foo',
@@ skipping 260 matching lines @@
     Response original = new Response.invalidRequestFormat();
     Response response = new Response.fromJson(original.toJson());
     expect(response.id, equals(''));
     expect(response.error, isNotNull);
     RequestError error = response.error;
     expect(error.code, equals('INVALID_REQUEST'));
     expect(error.message, equals('Invalid request'));
   }
 
   void test_fromJson_withResult() {
-    Response original = new Response('myId');
-    original.setResult('foo', 'bar');
+    Response original = new Response('myId', result: {'foo': 'bar'});
     Response response = new Response.fromJson(original.toJson());
     expect(response.id, equals('myId'));
     Map<String, Object> result = response.result;
     expect(result.length, equals(1));
     expect(result['foo'], equals('bar'));
   }
-
-  void test_setResult() {
-    String resultName = 'name';
-    String resultValue = 'value';
-    Response response = new Response('0');
-    response.setResult(resultName, resultValue);
-    expect(response.result[resultName], same(resultValue));
-    expect(response.toJson(), equals({
-      Response.ID: '0',
-      Response.RESULT: {
-        resultName: resultValue
-      }
-    }));
-  }
 }